`loading` initially starts as `null`? about react-fetch-component HOT 6 CLOSED

from react-fetch-component.

Oh...yeah, okay, I get it. Fair enough.

from react-fetch-component.

from react-fetch-component.

I agree. Bump the major ver and do that 😄 It might cause some confusion though if the loading behaviour changes depending on whether or not manual is set. It'd have to be well-documented.

I personally don't like the the extra render or the fact that I have to do additional checks, so I'm all for initializing loading to true. I understand that the HTTP request hasn't been kicked off yet, but from the UI perspective I just don't care if you tell me a lie 😛

from react-fetch-component.

@mnpenner Deployed as 7.0.0. loading will now be defaulted to true unless manual is set to true.

This will not save a render (still get 3 on the simple/typical case) but this should simplify handling loading state and not require something like this:

loading == null || loading ? (
  <Loading /> 
) : (
  <div>{data}</div>
)

from react-fetch-component.

@techniq Really? I just wrote up a simple test and it only renders twice unless you call setState twice in componentDidMount.

I think it's because this line gets called even when mounting. Not sure if it's necessary or not, but three renders probably isn't a big deal anyway.

Thank you for releasing 7.0! That makes things easier.

from react-fetch-component.