Giter Club home page Giter Club logo

Comments (9)

robjtede avatar robjtede commented on June 15, 2024 1

I guess you can only pin as far as the library itself does. Crates in the Rust ecosystem expect semver compatibility within a semver range.

In this case, everything works fine for stable users. However, ahash chose to automatically enable unstable features under nightly compilers, which is not recommended (for exactly this reason).

This issue is kinda surprising to me, because I would expect TFB to use a stable compiler.

from frameworkbenchmarks.

sebastienros avatar sebastienros commented on June 15, 2024

Could this sudden failure be due to some "floating" version on a dependency? Ideally all dependencies should be pinned. For instance I could find this "nightly" reference, could it make the build fail at some point:

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Rust/actix/rust-toolchain.toml#L2

from frameworkbenchmarks.

robjtede avatar robjtede commented on June 15, 2024

There isn't much we could have done about this. Nightly failures happen and libraries that opt in to using those unstable features automatically subscribe to dealing with these kinds of failures at the detriment of transitive dependencies. I trust that they're on it and this will be resolved in a couple of days.

from frameworkbenchmarks.

sebastienros avatar sebastienros commented on June 15, 2024

Do you mean that the [toolchain] argument is not the reason of this failure, or that it can't use a value like stable or 1.8.0?

from frameworkbenchmarks.

robjtede avatar robjtede commented on June 15, 2024

I haven't looked closely enough at other things other than the message you pasted:

error: could not compile `ahash` (lib) due to 1 previous error

ahash is at fault here, not Actix Web.

from frameworkbenchmarks.

sebastienros avatar sebastienros commented on June 15, 2024

I am definitely not blaming Actix, just wanted to understand why the benchmark started failing overnight as we are expected to pin all dependencies to prevent these issues.

from frameworkbenchmarks.

mkvalor avatar mkvalor commented on June 15, 2024

@sebastienros Whenever I see a failure for one of the frameworks I follow closely, I open a GitHub issue in that framework's repo directly. I have found that maintainers of frameworks are sometimes not aware for weeks when this kind of failure occurs. I recommend you try this in the actix repo's Issues page (if you have not yet done this).

from frameworkbenchmarks.

robjtede avatar robjtede commented on June 15, 2024

@mkvalor there's no need, I'm right here :P

from frameworkbenchmarks.

mkvalor avatar mkvalor commented on June 15, 2024

Oof, I originally suspected so; should've just looked at top contributors to Actix. But the pronoun in the third comment and the reference to the project in the fifth comment tipped my suspicion in a different direction. All good!

from frameworkbenchmarks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.