add deis apps:rename command about controller HOT 18 OPEN

From @deis-admin on January 19, 2017 23:23

From @mboersma on January 21, 2014 17:21

+1 for this.

from controller.

From @deis-admin on January 19, 2017 23:23

From @gabrtv on January 21, 2014 17:22

Big +1. Marking this as a production requirement.

from controller.

From @deis-admin on January 19, 2017 23:23

From @tombh on January 21, 2014 17:24

BTW, on a related issue, I noticed that utils.generate_app_name() doesn't check for a pre-existing app of the same name, so there is a slim possibility of a duplicate key error.

from controller.

From @deis-admin on January 19, 2017 23:23

From @gabrtv on January 21, 2014 17:25

@tombh yup, we should write that up as a separate issue. I imagine it can be fixed w/ a small PR.

from controller.

From @deis-admin on January 19, 2017 23:23

From @nathansamson on January 22, 2014 17:48

How hard would this be to implement?

Is it enough that the ID of the app is changed in the DB (and all dependant tables like Containers, Perms, ...) or is this going to cause trouble for running containers (who now have the wrong naming scheme?)
Can we rename docker containers?

from controller.

From @deis-admin on January 19, 2017 23:23

From @gabrtv on January 22, 2014 17:56

I don't believe Docker containers can be renamed (yet). However, since containers are currently ephemeral and move around between hosts, this shouldn't be a problem.

We should explore having apps:rename roll a new release, which would result in a new set of containers, while garbage collecting the old.

from controller.

From @deis-admin on January 19, 2017 23:23

From @developerinlondon on June 12, 2014 16:37

which version is this on? i cant see it in Deis 0.9.1 ?

from controller.

From @deis-admin on January 19, 2017 23:23

From @bacongobbler on June 12, 2014 16:39

@developerinlondon the PR was closed as it was too hard to test. This is still a WIP.

from controller.

From @deis-admin on January 19, 2017 23:23

From @developerinlondon on June 12, 2014 20:22

what kind of testing framework are you guys using? i would have thought something like http://falcao.it/sure/ would be quite good for this.

from controller.

From @deis-admin on January 19, 2017 23:23

From @bacongobbler on June 12, 2014 20:36

Right now it's just a bunch of rake tasks, but @mboersma and @smothiki are currently re-writing our integration tests in Go. Out logger's in Go, deisctl will be written in Go, the Deis client will eventually be re-implemented in Go, one day I hope to re-write the controller in Go, etc. It's just a good fit for us. The controller is the only special snowflake written in Python (as well as the client, but see above).

from controller.

From @deis-admin on January 19, 2017 23:23

From @bacongobbler on July 16, 2014 22:51

We have domains:add and users can create specific app names with apps:create [id]. I'm not too sure if apps:rename is too critical of a feature, as domains:add puts us at feature-parity for running an app under a different application name e.g. deis domains:add example-app-v2.example.com is an alias for the original application name.

@gabrtv is this acceptable for the time being and we can close this issue by design, or is there another use case that's missing here?

from controller.

From @deis-admin on January 19, 2017 23:23

From @gabrtv on July 30, 2014 1:34

@bacongobbler I think we ultimately want an apps:rename command to model Heroku. However as you mentioned there are a number of workaround, so it's not critical.

from controller.

From @deis-admin on January 19, 2017 23:23

From @jessefulton on December 19, 2014 16:10

+1 on this

from controller.

From @deis-admin on January 19, 2017 23:23

From @olalonde on March 17, 2015 8:27

+1. Personally, I don't mind what the docker containers are called. I would just like to have more descriptive names when I run deis apps. Internally, deis apps:rename could just map the new name to the actual docker container name without changing it.

from controller.

From @deis-admin on January 19, 2017 23:23

From @olalonde on April 13, 2015 17:13

Has this been implemented yet?

from controller.

From @deis-admin on January 19, 2017 23:23

From @mboersma on April 13, 2015 17:19

Has this been implemented yet?

Not yet. We would love to see a PR submitted. 😄

from controller.

From @deis-admin on January 19, 2017 23:23

From @carmstrong on April 13, 2015 17:20

I would just like to have more descriptive names when I run deis apps

apps:rename hasn't been implemented. Are you aware that you can give an app a descriptive name when you create it? There's a parameter for the application's name, and you can give it a friendly one:

$ deis help create
Creates a new application.

- if no <id> is provided, one will be generated automatically.

Usage: deis apps:create [<id>] [options]

Arguments:
  <id>
    a uniquely identifiable name for the application. No other app can already
    exist with this name.

Options:
  --no-remote
    do not create a `deis` git remote.

  -b --buildpack BUILDPACK
    a buildpack url to use for this app

  -r --remote REMOTE
    name of remote to create. [default: deis]

from controller.

From @deis-admin on January 19, 2017 23:23

From @Joshua-Anderson on July 15, 2015 21:23

I'd be happy to take a look at this once the go client rewrite has settled down.

from controller.