Comments (3)
tconbeer
commented on May 31, 2024
Thanks for the report! union is formatted properly if the second query is not wrapped in parentheses, but I agree with you that this is a bug, and the second query should not be indented
from sqlfmt.
tconbeer
commented on May 31, 2024
To fix this I think we should create a new token type, SET_OPERATOR to distinguish union from a normal unterminated keyword like select. Then we update the logic for mutating open_brackets so that set operators don't get added to that list (but do have the existing behavior of popping existing unterminated keywords)
from sqlfmt.
Rainymood
commented on May 31, 2024
Cheers! Such a fast fix!
from sqlfmt.
Related Issues (20)
- Indent config
- Add rule for: query defines a CTE (common-table expression) but does not use it.
- sqlfmt + reviewdog HOT 2
- sqlfmt add space which is invalid HOT 2
- sqlfmt introduces space in scientific notation HOT 2
- formatting does not work in queries defined as variables HOT 3
- the expression of jinja has indent bug. HOT 2
- linux/amd64 docker builds failing HOT 2
- --exclude option doesn't work on Windows HOT 1
- integer division // operator reformatted as comment HOT 2
- for...else...endfor statement does not work HOT 1
- Column formatting breaks with unary operators HOT 2
- Parsing error on valid SQL using string literals with single quotes HOT 1
- One specific BQ-DBT SQL file gets wrongly formatted and becomes unusable
- Support formatting stdin? HOT 2
- Support pg-promise Query Files with Named Parameters HOT 2
- Case-sentitive identifiers within object navigation expressions are lowercased HOT 2
- Request: Support leading commas HOT 1
- sqlfmt incorrect reformatted JSON access path, breaking all accesses. HOT 1
- Don't merge lines if they contain a trailing comma HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlfmt.