Prerequisites about test262 HOT 6 CLOSED

This seems overcomplicated. I would just split out tests that use proxies into a separate file, e.g. Array.prototype.contains-proxies-this-arg or something.

from test262.

Sure, but then that test fails and it's up to the person running the test to know that it's an expected failure in a host without proxies. Imagine testing a polyfill in an ES5 implementation - it would be nice to have the proxy integration tests automatically filtered out.

I agree, though, that this isn't super critical, but it would be nice to have IMO :)

from test262.

Having an es6 feature tag on the test that says "Proxy" would be enough to tell us to skip that test if the host doesn't have proxies. 

Is that enough to address both the prerequisite and the interaction issue? 

Annotate a test with the es6 features and abstract operations it touches. That's enough to get us an idea of coverage/lack of and to rule out tests that hit uncovered operations. 

es6: [Array#find, IsCallable, arrowfunctions]

On Mon, Oct 27, 2014 at 4:56 PM, Brian Terlson [email protected]
wrote:

Sure, but then that test fails and it's up to the person running the test to know that it's an expected failure in a host without proxies. Imagine testing a polyfill in an ES5 implementation - it would be nice to have the proxy integration tests automatically filtered out.

I agree, though, that this isn't super critical, but it would be nice to have IMO :)

Reply to this email directly or view it on GitHub:
#111 (comment)

from test262.

Is that enough to address both the prerequisite and the interaction issue?

It's not enough I don't think. You still need some way of determining if the feature is present, aka a mapping of "Proxy" to return typeof Proxy === 'function'.

from test262.

It's not enough I don't think. You still need some way of determining if the feature is present, aka a mapping of "Proxy" to return typeof Proxy === 'function'.

Oh, I thought we were going to do that manually. So if I'm testing v8 today I would have some sort of features.json file with Proxy: false.

Even so, whether it's manual or automatic, tagging a test as features: [Proxy] is a good start in being able to filter out these cross-es6-feature dependencies

from test262.

We ended up using the features tag, which is not really consumed, but at this point I think it's too late to fix unless we have a new plan. Closing it for now.

from test262.