Github button isn't removed. about moon HOT 18 CLOSED

Hey @ToddMurphy92 ,
The issue does exist. Like I said before, I think it has something to do with using the 'site.github' name for the variable. Try renaming the variable to something else and replacing it wherever it is being used in the theme. At least that's how I fixed it.

@libeclipse Did you actually try removing the github button? This issue only occurs with the github button and not the others.

PS: Don't know why the creator hasn't resolved it yet.

from moon.

@ToddMurphy92 Aah okay. I don't really have it on my system to give it a go. But in case you would like to quickly try, I think you need to 'mainly' change it here (after changing it in the _config.yml) : https://github.com/ToddMurphy92/ToddMurphy92.github.io/blob/master/_includes/social-links.html

from moon.

You've probably accidentally changed some file but I cannot really check since it doesn't seem to be on your website.

from moon.

Well, I did consider that. So, I forked a new version and just commented the line with respect to the github link. And still the problem persists.

Then I resolved the issue by renaming the 'site.github' variable to something else. And it worked.
I think it might have something to do with this: https://help.github.com/articles/repository-metadata-on-github-pages/

from moon.

PS: My website isn't using this theme anymore.

from moon.

Please close this issue then if it's no longer relevant.

from moon.

Don't you think it is still relevant as the issue isn't actually resolved?
I did find a workaround but the issue still exists in the theme itself.

from moon.

I'm not too sure. I myself have never encountered the issue or anything
similar. If you're sure it wasn't an error you made then fair enough.

from moon.

I'm also getting this issue with http://toddmurphy.me/ which is running this theme currently. Only things I have changed is the config and navigation .yml files.

from moon.

In the creators defence you did say you were no longer using the theme, and so there's not much point in fixing something that doesn't impact anyone (or at least not anyone the dev knows of).

Thanks for the update though. I'll give that a shot, I'll let you know how I go (probably horribly, I'm pretty bad when it comes to git and all things coding).

from moon.

So I had a quick look into removing 'site.github' variable/references and decided I'll just leave this as is and see what the dev says if/when they respond. This isn't really urgent for me, my site doesn't get much traffic and on the rare occasion it does it's unlikely to be from anyone who would be interested in seeing git.

from moon.

@ToddMurphy92 Haha.. yeah. I am not trying to attack or something. It's a thin line, I have a workaround but the issue still exists. :P

from moon.

That did indeed 'fix' the issue for the main page. Still shows up in the about bar though.

from moon.

Modified nav.html, fixed the about bar issue :)

from moon.

Yay! Guess, you know now what to do!

PS: I was about to give you a hint. xD

from moon.

Actually yeah I never tried to remove the github button.

As for @TaylanTatli, he's currently in exam seasons without a PC, so it's unlikely there'll be any fixes any time soon. Might be worth asking for commit rights.

from moon.

Hey, all, the issue does exist. When running this locally using Jekyll, the GitHub button doesn't show if the username is removed. When hosting on GitHub Pages, the button shows, and hovering over the button shows http://github.com/{.

from moon.

It should be fixed with cd451e3. It was because of Github Metadata.

from moon.