Giter Club home page Giter Club logo

Comments (3)

deremer avatar deremer commented on May 26, 2024

just adding :line_items to the attr_reader and commenting out the line_items method seems to give us the access to the line_items we are looking for...

https://github.com/goposse/taxjar-ruby/blob/master/lib/taxjar/breakdown.rb

but then we have to access the attributes by their symbols instead of as methods (e.g., a.breakdown.line_items[0][:id])

from taxjar-ruby.

fastdivision avatar fastdivision commented on May 26, 2024

@deremer Should be fixed now w/ additional spec. Thank you for reporting this issue! πŸ˜„

from taxjar-ruby.

deremer avatar deremer commented on May 26, 2024

No problem. Thanks for taking a look and fixing quickly. As mentioned in my follow-up comment, the code is also like this in order.rb and refund.rb, but I haven’t tested to see if the same problem exists in those places.

--Β 
David DeRemer

On October 9, 2015 at 2:15:14 PM, Jake Johnson ([email protected]) wrote:

@deremer Should be fixed now w/ additional spec. Thank you for reporting this issue!

β€”
Reply to this email directly or view it on GitHub.

from taxjar-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.