Comments (3)
just adding :line_items to the attr_reader and commenting out the line_items method seems to give us the access to the line_items we are looking for...
https://github.com/goposse/taxjar-ruby/blob/master/lib/taxjar/breakdown.rb
but then we have to access the attributes by their symbols instead of as methods (e.g., a.breakdown.line_items[0][:id])
from taxjar-ruby.
@deremer Should be fixed now w/ additional spec. Thank you for reporting this issue! π
from taxjar-ruby.
No problem. Thanks for taking a look and fixing quickly. As mentioned in my follow-up comment, the code is also like this in order.rb and refund.rb, but I havenβt tested to see if the same problem exists in those places.
--Β
David DeRemer
On October 9, 2015 at 2:15:14 PM, Jake Johnson ([email protected]) wrote:
@deremer Should be fixed now w/ additional spec. Thank you for reporting this issue!
β
Reply to this email directly or view it on GitHub.
from taxjar-ruby.
Related Issues (20)
- Calculate Sales Tax for a Saas based product without shipping HOT 1
- Support for Ruby 1.9.3 HOT 1
- How does the the dependency on model_attributes work? HOT 2
- Unable to parse invalid JSON when service unavailable HOT 4
- Occasional InternalServerError on address validation HOT 1
- HTTP::Error: Unknown MIME type: text/html in rare cases HOT 2
- Stripe Subscription Integration Questions HOT 6
- Support for ruby 2.7 HOT 6
- Client doesn't throw Taxjar exceptions during outage
- Client doesn't throw Taxjar exceptions during outage HOT 1
- Cannot create customer with the API HOT 1
- Taxjar::Client#show_order is supposed to return exemption_type but does not. HOT 2
- http dependency bump for ARM support? HOT 1
- Different states tax calculation HOT 1
- 2000 dodge
- default User-Agent can cause 500 errors HOT 1
- Bump http gem dependency to support v5 HOT 1
- Support for API versions; gem should upgrade before it is forced HOT 1
- Missing v.3.0.3 tag, so can't see the diff in GitHub HOT 1
- Taxjar::Base has confusing mixed data states
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from taxjar-ruby.