Giter Club home page Giter Club logo

Comments (6)

Arcanemagus avatar Arcanemagus commented on May 22, 2024

Even better (at least in my opinion) would be to not store the password at all. I've changed plexWatch/Web to only store the authentication token. If the token is ever invalidated it directs the users to the settings page to generate a new one.

I don't want to be responsible for storing the password, and encrypting it is pointless as the decryption must be able to be performed by the same application... and thus just as easily accessible as the password.

from tautulli.

drzoidberg33 avatar drzoidberg33 commented on May 22, 2024

Indeed. There is actually no need to save the password. I'll work that into the next commit.

Thanks.

from tautulli.

drzoidberg33 avatar drzoidberg33 commented on May 22, 2024

Latest commit now only stores your token (d2c65e6)

You can enter it manually or use the new javascript auth tool which talks directly with plex.tv.

from tautulli.

Arcanemagus avatar Arcanemagus commented on May 22, 2024

That's even better than sending it back to the server at all, I might have to move plexWatch/Web to that model 😛.

from tautulli.

drzoidberg33 avatar drzoidberg33 commented on May 22, 2024

It made the most sense to do it this way. Otherwise you you're adding another layer to slow things down as well as the issue of sending the credentials over an insecure connection if the user hasn't enabled SSL on the installation.

from tautulli.

Arcanemagus avatar Arcanemagus commented on May 22, 2024

Yep, exactly. Also this way you are using the browser to handle the HTTPS, which is going to be one of the most up to date things out there for support of that. Python probably does this better but in PHP land quite often you are stuck with very old OpenSSL libraries unless the user has done some customization.

from tautulli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.