Giter Club home page Giter Club logo

Comments (7)

aatmanvaidya avatar aatmanvaidya commented on July 1, 2024

this is a know bug happening in brave and chrome, the issue happens with this line of the code

const tabsCurrent = await userBrowserTabs.query({

Here userBrowserTabs - basically this part of the code is not able to recognise chrome as a browser type,
but the functionality of the code is working

so practically, if we remove the reload pop-up while saving preference, this bug will go away.

from uli.

aatmanvaidya avatar aatmanvaidya commented on July 1, 2024

when adding a 2nd slur either manually or via right-click - these 2 errors pops up in the chrome extension errors window

Unchecked runtime.lastError: Cannot create item with duplicate id add-slur
Unchecked runtime.lastError: Cannot create item with duplicate id add-crowdsource-slur

Investigate why this is happening?

from uli.

duggalsu avatar duggalsu commented on July 1, 2024

This bug is causing the following issue in the current version -

  • Manually add slur to slur list and click Save. A notification shows that settings have been saved. Reload web page. Slur replacement stops working.
  • Add another slur or simply click Save in preferences a 2nd time. Uli shows a popup and a notification shows that saving settings failed. Slur replacement still does not work

from uli.

aatmanvaidya avatar aatmanvaidya commented on July 1, 2024

The issue where chrome shows an error on enabling/disabling slur replacement has been fixed in this PR - #401

from uli.

aatmanvaidya avatar aatmanvaidya commented on July 1, 2024

Found a new bug, if slur replacement is checked off and a user adds a word to the slur list and clicks on save, slur replacement starts working.

Will try to wrap this up over the weekend

from uli.

aatmanvaidya avatar aatmanvaidya commented on July 1, 2024

The error arises because the Add slur list text area is in a form and the checkbox is outside the form, the local preferences in the form are not being updated.

from uli.

aatmanvaidya avatar aatmanvaidya commented on July 1, 2024

This issue is resolved - #493

from uli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.