Giter Club home page Giter Club logo

Comments (3)

Leonidas-from-XIV avatar Leonidas-from-XIV commented on July 22, 2024

I am not sure myself but I believe I have a decent hypothesis why this happens based on this test:

opam-monorepo/test/test_duniverse.ml

Lines 153 to 169 in 5e22093

make_test ~name:"Aggregates repos"
~summaries:
[
summary_factory ~name:"y" ~version:"v" ~url_src:(Other "u") ~dev_repo:"d" ();
summary_factory ~name:"y-lwt" ~version:"v" ~url_src:(Other "u") ~dev_repo:"d" ();
]
~expected:
(Ok
[
{
dir = "d";
url = Other "u";
provided_packages =
[ { name = "y-lwt"; version = "v" }; { name = "y"; version = "v" } ];
};
])
();

opam-monorepo only supports one tarball per dev-repo, because if there are multiple tarballs, their contents might have overlapping source trees (and in fact, all opam packages from the same dev-repo released with dune-release share the same tarball which contains the entire source tree), so it needs to pick one or decide how to merge multiple source trees (which I would say is quite difficult, especially if the tarballs correspond to different versions of the dev-repo). The way it does so is by determining the dev-repo, but if they are missing the field, then it can't figure out which tarballs to aggregate.

It might be useful to display a warning if a package is missing the dev-repo, however this might be printing a lot of warnings for conf-packages or similar, so it would need to make sure to only warn on "normal" packages.

from opam-monorepo.

kit-ty-kate avatar kit-ty-kate commented on July 22, 2024

It might be useful to display a warning if a package is missing the dev-repo, however this might be printing a lot of warnings for conf-packages or similar, so it would need to make sure to only warn on "normal" packages.

conf packages usually have the conf flag so they could be easily filtered off this way.

from opam-monorepo.

Leonidas-from-XIV avatar Leonidas-from-XIV commented on July 22, 2024

That's true; certainly worth a try implementing a warning to see whether it will output some useful messages.

from opam-monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.