Comments (19)
I actually don't know much about helm...
I see a couple of things like this:
Seems like both of those are candidates for matching up with the pod-reaper version correct?
Is there a repository where new versions are updated? How is it being used right now?
from pod-reaper.
Trying to ask this a different way. With charts also being versioned, are the charts published anywhere (or are they someone pulled directly from github/here)? Trying to see if/when these have been published.
I've got a lot to learn here!
from pod-reaper.
Nice, so regarding that, the strategy that is most common to opensource projects is to create a separate repo only for the helm files, create the helm package and add it to the repo as well and then integrate that repo with the CNCF project https://artifacthub.io/.
After that we will be able to install the helm charts using only the helm repo add
and helm install pod-reaper --version XYZ
I can see those steps ahead.
- Create a new repo and on that, include only the helm yaml files and needs.
- Create the new stable helm package with
- [ ] Create the structure likemkdir stable && helm package . -d stable/
- [ ] Create the helm packagehelm package . -d stable/
- Enable the github pages in the repository properties
- Create an account in artifacthub.io, create a new repo and integrate that with the GitHub pod-reaper github Page
Let me know if I can help somehow.
from pod-reaper.
Hey, I took the liberty to execute the steps above, but I would only use it if you agree, and then I would transfer the ownership to you.
https://github.com/rogerioefonseca/pod-reaper-helm
https://artifacthub.io/packages/helm/pod-reaper-chart/pod-reaper
from pod-reaper.
Only managed to find a bit of time to dig at this...
What's the advantage of having a separate repository for just the chart? Doesn't that mean keeping both in sync?
Mostly just trying to understand and I suspect that is in part because of how long I've used the pattern of "just have full kubernetes manifest files live in my application's repository, fully codifying the app, deployment configuration, and pipeline together in the same repo".
from pod-reaper.
So that is a nice question and my points are pretty much related to your comment when you mention the "just have full kubernetes manifest files live in my application's repository, fully codifying the app, deployment configuration, and pipeline together in the same repo". :)
Helm Charts have its only responsibility and it is more related to Kubernetes rather than your application, having the Helm charts in a separate repo would:
Pros:
- Make the repository cleaner easy to read(and it is not everyone that needs or knows how to deal with Helm).
- Helm Charts depend on Helm versions and having it in a reparate repo would make it easier to release/tag it.
- As it is an open-source project it would be easier to have the community contributing to it in a direct way.
- We would be using the pattern that CNCF is using, so it would be kind of a "Certificate of good practice"(https://codefresh.io/docs/docs/new-helm/helm-best-practices/)
- Maybe in the future, we could think of running the pod-reaper in an AWS lambda function or an ECS Cloud formation code as well, and then we would have to increment the folder structure.
Cons:
- If you have to change something that affects the helm you would need to create 2 MR's, one for each repo
- Deal with different pipelines and related resources
from pod-reaper.
Ping!
Happy new year!!
from pod-reaper.
I'm currently leaning towards trying to do it in this repo, but mostly because it means fewer PRs, makes it easier to automate between release of the helm chart and the code. Also because I'm not an owner/admin of the Target organization, so I'd have to have someone else make it (unless I want to do it under my personal space).
from pod-reaper.
Yep, fair enough, I still did not understand the fewer PR's that you mentioned since the Helm charts are not really being changed that much.
Can you please keep the Helm version the same as the repo? :)
from pod-reaper.
Oh, maybe my understanding is wrong... wouldn't I want to update the helm chart to use the latest version of the pod-reaper in the helm chart each time I update the pod-reaper?
I'm mostly thinking about this version number:
from pod-reaper.
No it is not that one.
The chart version should match the TAG version -
from pod-reaper.
Ping...
from pod-reaper.
Thanks for the ping. I'm mostly just swamped with work this week. I promise it's still on my to-do list
Is there a date you'd really like to see this by? Or just as ASAP thing?
In either case, honestly appreciate the reminders!
from pod-reaper.
haha, for me it would be an ASAP thing, haha.
:)
from pod-reaper.
@rogerioefonseca
Way too much I'm not tracking with helm.
Any chance you'd be up for a pair programming session sometime?
I think there are a few things needed to make this work that'd be overstepping my bounds as I'm not an admin on this repo. So I'm considering doing this all myself on a git repo (very similar to what you had), but I'd like to know more about expected use cases.
When this is all working properly, what are some examples of commands you want to see working?
from pod-reaper.
@slushpupie Do you (or know someone else) know/use helm well/often?
Seems like some steps here would be asking for another repo or at least initializing git admin pages/setting up an account on artifacthub.io
Struggling with a back and forth between wanting to keep everything together and breaking it out/letting someone else (even if it's me) own the helm chart.
from pod-reaper.
Sure! We can do pair programming and discuss the pros and cons.
Let me know if one of these slots works for you:
https://calendly.com/d/cmr-zbp-64k/helm-chart-conversation
Regarding your points:
1 - After having a new repository configured with Github pages and published in artifact.io I would just need to:
helm repo add pod-reaper https://rogerioefonseca.github.io/pod-reaper-helm/charts
helm install pod-reaper
2 - And yes I use Helm often
from pod-reaper.
got a This calendar is currently unavailable.
Also pinged an admin on the repo to see what they think. Otherwise, I can set it up under my personal space if/until we sort something out.
Sincere apologies, but I've been swamped the last few weeks and I'm still catching up. Still poking at this when I catch a few minutes here and there.
from pod-reaper.
Hey there, sorry for the lack of reply!
I manage here inside do check the helm version internally, was a little tricky but worked.
If you are still opened to, let me know when it would be a good date to discuss this topic, it is still relevant in my opinion.
Best
from pod-reaper.
Related Issues (20)
- Easier local development HOT 4
- Allow default configuration override with annotations HOT 14
- Log messages not parsed by Stackdriver HOT 4
- Explicit rule enable
- Setup CI/CD outside of docker
- Deployment bug HOT 2
- Schedule doesn't seem to work correctly HOT 7
- Dry run mode HOT 2
- Update Dependencies to use Go Modules HOT 3
- Helm chart HOT 5
- Does pod-reaper act on 1 pod at a time? or all pods simultaneously HOT 10
- Pod status rule is misleading HOT 3
- Upgrade docker base image to use golang 1.15 HOT 3
- In nonprod, reduce resouces: Reap pod/apps so they don't consume resources on weekend HOT 1
- Docker builds no longer happening automatically HOT 5
- v1beta1 ClusterRole is deprecated in v1.17+, unavailable in v1.22+; Use v1 ClusterRole
- MAX_DURATION option does not count the Pod Status Start time HOT 3
- Pod reaping strategy HOT 5
- Improve dry run log accuracy
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pod-reaper.