Giter Club home page Giter Club logo

Comments (6)

vrogach2020 avatar vrogach2020 commented on July 28, 2024

It's a working case. But we have to improve error reporting - if the result returned from lua function is not null, but no fields in entity match the metadata or metadata is null.

from cartridge-springdata.

andrei-punko avatar andrei-punko commented on July 28, 2024

In similar case we resolved the issue by using same @Tuple not only for entity class but for related repository class too.
Not sure is it right way

from cartridge-springdata.

ArtDu avatar ArtDu commented on July 28, 2024

It's strange that the SimpleTarantoolRepository functions work when the wrong space name is specified in @Tuple. But when using the @Query function where the return will be the same as findAll(from SimpleTarantoolRepository) - crud.select - there will be the same number of tuples, but the object fields will be NULL.

from cartridge-springdata.

vrogach2020 avatar vrogach2020 commented on July 28, 2024

when the wrong space name is specified in @Tuple

I think we should throw exception in this case

from cartridge-springdata.

wey1and avatar wey1and commented on July 28, 2024

We need to analyze the cases of working with methods in the repository. We need to understand which cases are working and which are not. For example: default methods, like save and find that return a map or a tuple, etc.

from cartridge-springdata.

ArtDu avatar ArtDu commented on July 28, 2024

If we consider only those cases where we exactly forgot to indicate @Tuple, so far I see one case where exactly throwing Exceptions needs to be done

  1. When we forgot to specify @Tuple, but our return type is tuple (number indexed table) - then cartridge-java converts the response to an ArrayList and passes it on for conversion to cartridge-springdata. We can check if ArrayList arrived to mapToEntity and then raise specific error, because we only accept Map or TarantoolTuple or PrimitiveType.

from cartridge-springdata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.