Add tests name convention and change tests to this convention about cartridge-springdata HOT 5 CLOSED

Thank you for the proposal!

I suggest using only test_ for method prefixes instead of some names, the test method name already includes the "shouldSomething" part which describes it.

from cartridge-springdata.

Thank you for the proposal!

I suggest using only test_ for method prefixes instead of some names, the test method name already includes the "shouldSomething" part which describes it.

Done

from cartridge-springdata.

I'll try to finalize the agreement:

1 Name of test method must not violate linter rules and
generate compiler warnings (must not contain special characters, be longer than 120 chars etc).

2 These points of testcase must be readable and simple:

• test object (class, method)
• action (input)
• expected reaction of system (output)

It's good when they can be included into test method name but it's not always possible.
When the description is too large then testcase should contain a comment on points mentioned above.

3 Do not perform a total refactoring of existing codebase.
Just leave the code better than it was after making changes.

from cartridge-springdata.

Also maybe use this pattern ?

@akudiyar @wey1and

test_[method]_when[condition]_then[reaction]
For example:
test_helloWorld_whenCalled_ThenPrintHelloWorld()

instead of this

test_[methodName/scenarioName]_should[Action]_if[Condition]

[methodName/scenarioName]_ - is optional.
if[Condition] - is optional. You can omit this if the execution is straightforward.

from cartridge-springdata.

Thanks to all!
Based on the discussion, I brought the initial version to the final one.

from cartridge-springdata.