Connection pool should be cached against server-spec about carmine HOT 2 CLOSED

Hi Kiran, thank you for the clear report!

But after reading pooled-conn and conn-pool I found out that pools are maintained against pool-opts and have nothing to do with server-spec.

Sort of. Each set of unique pool options will yield a [memoized] single pool. But the pool semantics are that connections are actually keyed by their spec.

So, for example, you can use one pool for 2 completely different server specs and each pool request for a connection will be dependent on the spec, and yield a connection for that particular spec.

Basically, you can think of the Carmine 'pool' as a map of sub-pools, keyed by connection spec. Does that make sense? (I'm really tired, might not be the most articulate atm ^^).

You should be able to confirm this behaviour at the REPL by using the same pool opts against two different Redis servers. You [should] get the behaviour you would want/expect, even though there's really only one "Pool" being materialised under the covers.

Does that address your concern?

from carmine.

Yes, I understood how you architected the pools. Thanks for this explanation!!

PS: closing the issue

from carmine.