Comments (3)
Awesome, looks good!
Random comments:
- Would prefer
set-done
to be calledmark-as-done
(slightly clearer to me). mark-as-done
andunlock
should be private to remove the temptation for consumers to use them.- I like that you're marking jobs as done on an exception - that was an oversight on my part.
- An :error handler response should behave like an exception (i.e. log error & mark message as done).
make-dequeue-worker
will need a small docstring update to mention this new feature.
This will be a nice addition, thanks for taking care of the message queues as you have.
from carmine.
Cool ill make the changes and issue a pull request,
I use the job queue (and carmine) quite a lot so its my pleasure to be able to contribute something back :)
from carmine.
See my pull request
from carmine.
Related Issues (20)
- `parse-map` stop working when upgrade from 3.2.0 to 3.3.0 HOT 10
- broken link to nippy in README HOT 1
- Support commands in RediSearch, RedisJSON, RedisTimeSeries, RedisBloom HOT 2
- Handling locked messages after JVM crash HOT 3
- Carmine v4 first core pre-release
- Carmine v4 Tundra
- Carmine v4 Sentinel support
- Carmine v4 Cluster support
- message-queue/queue-names is broken (and untested) HOT 1
- Feedback on v3.3 migration instructions HOT 3
- Silently catches OutOfMemoryErrors without rethrowing HOT 8
- Mutiple atomic transactions as a pipeline HOT 3
- Unexpected behavior with `(parse-map ... :keywordize)` HOT 3
- Does Carmine support DragonflyDB? HOT 10
- Connection loss/failure detection on MQ HOT 12
- Pub/Sub posts to wrong handler fn HOT 5
- Carmine message-queue: allow throughput control HOT 4
- Block on handler being ready when creating new listeners? HOT 4
- Closing the listener produces at least one error message to handler, sometimes several. HOT 4
- Carmine redis does not support to read from replicas HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carmine.