More fine grained job retry/success about carmine HOT 3 CLOSED

Awesome, looks good!

Random comments:

• Would prefer set-done to be called mark-as-done (slightly clearer to me).
• mark-as-done and unlock should be private to remove the temptation for consumers to use them.
• I like that you're marking jobs as done on an exception - that was an oversight on my part.
• An :error handler response should behave like an exception (i.e. log error & mark message as done).
• make-dequeue-worker will need a small docstring update to mention this new feature.

This will be a nice addition, thanks for taking care of the message queues as you have.

from carmine.

Cool ill make the changes and issue a pull request,

I use the job queue (and carmine) quite a lot so its my pleasure to be able to contribute something back :)

from carmine.

See my pull request

from carmine.