Grouping by not using subRows about table HOT 2 OPEN

In case you confirm this to be an issue/not intended behavior, it seems the culprit is here:
https://github.com/TanStack/table/blob/main/packages/table-core/src/utils/getGroupedRowModel.ts#L168

The groupBy function only handles top-level rows. I was able to go around this and implement desired behavior (i.e. values from all rows and subRows get grouped by) by making it recursive like this:

function groupBy<TData extends RowData>(
  rows: Row<TData>[],
  columnId: string,
  opts: Partial<{
    groupMap: Map<any, Row<TData>[]>;
  }> = {}
) {
  const groupMap = opts.groupMap ?? new Map<any, Row<TData>[]>();

  return rows.reduce((map, row) => {
    const resKey = `${row.getGroupingValue(columnId)}`;
    const previous = map.get(resKey);
    if (!previous) {
      map.set(resKey, [row]);
    } else {
      previous.push(row);
    }
    if (row.subRows) map = groupBy(row.subRows, columnId, { groupMap: map });
    return map;
  }, groupMap);
}

Looking forward to know what you think of this. This would probably be a breaking change for some? Since we can pass a getGroupedRowModel function to useReactTable, that's probably what I'll do for the time being. However, maybe a table option could be added to allow this behavior?

from table.

I need to display tabular data by groups so that above each group there is a row that is the group header and I would also like to add a button to hide the group in it, but the virtualizer obliges me not to group the data and go through rows and not leaf or flat rows. Otherwise, it doesn't work properly. Are there any examples that I could look at?

The example in the screenshot was taken from examples -> subComponent, but I can't reproduce this using c virtualizer

from table.