Giter Club home page Giter Club logo

Comments (6)

TkDodo avatar TkDodo commented on May 29, 2024

@ardeora can you have a look please? FYI, this is reproducible with normal useQuery as well, so it isn't suspense related imo

from query.

ardeora avatar ardeora commented on May 29, 2024

Okay will take a look at it today!

from query.

ardeora avatar ardeora commented on May 29, 2024

@TkDodo The change in #7008 broke this feature. This line specifically https://github.com/TanStack/query/pull/7008/files#diff-b5729917de14b1b87b04fa82d78a8abcafd81972cc9af9e8586ef27527d77ebbL332

When we click Restore Loading we set the initial (user-defined) options back on the query but since data is undefined we do not end up cancelling the infinite fetch query set here and therefore the query is in a perpetual loading state. I have a workaround working but this would involve resetting the query which would reset some state like dataUpdatedCount back to 0. Maybe this should be the expected behavior anyway?

from query.

TkDodo avatar TkDodo commented on May 29, 2024

yeah I think that's okay 👍

from query.

ardeora avatar ardeora commented on May 29, 2024

Actually nevermind! Fixed it without needing the workaround! 😅

from query.

ardeora avatar ardeora commented on May 29, 2024

Should be fixed in devtools v5.28.10+. Here is the reproduction with the new version https://stackblitz.com/edit/tanstack-query-baap5y?file=package.json that has been fixed

from query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.