Giter Club home page Giter Club logo

Comments (6)

TkDodo avatar TkDodo commented on May 30, 2024 1

when Page mounts, it sets the query, which is in error state by then, back to loading state, after which the parent unmounts the Page and then it goes back into error state, mounting the Page, triggering another refetch.

This is the "expected" behaviour if you mount children like that without error handling, and the default retryOnMount: true setting.

from query.

cuzfrog avatar cuzfrog commented on May 30, 2024

Given that you agree to change current behavior, I'm happy to create a PR.

from query.

cuzfrog avatar cuzfrog commented on May 30, 2024

the refetch triggered in the Page should only affect the loading in the Page not in the parent.

I don't think that effect effectively propagated upwards forming a loop is "expected behavior"...

from query.

TkDodo avatar TkDodo commented on May 30, 2024

the refetch triggered in the Page should only affect the loading in the Page not in the parent.

if you use the same queryKey, there is only one cache entry, and that entry goes into loading state, and all components that are interested in that state will be informed about it.

from query.

cuzfrog avatar cuzfrog commented on May 30, 2024

loading should not be part of the shared cache. only data should be. loading is just a status from the initiator's perspective.

from query.

TkDodo avatar TkDodo commented on May 30, 2024

That might be what you want but it's not how it works because that's not how this lib was designed to work.

from query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.