Giter Club home page Giter Club logo

Comments (16)

kvaster avatar kvaster commented on June 2, 2024 2

We experiancing same problem with tamagui and 'PortalHostComponent' when trying to migrate to new architecture.

from tamagui.

natew avatar natew commented on June 2, 2024 1

Fixed in https://github.com/tamagui/tamagui/releases/tag/v1.98.0

from tamagui.

sync avatar sync commented on June 2, 2024 1

pr here: facebook/react-native#44586

from tamagui.

sync avatar sync commented on June 2, 2024

you can temporarily fix it by patching this file:

node_modules/@tamagui/portal/dist/cjs/GorhomPortal.native.js

And change this method on line 182:

from

    var next = function(value) {
      (0, import_react.startTransition)(function() {
        dispatch(value);
      });
    };

to

    var next = function(value) {
        dispatch(value);
    };

from tamagui.

sync avatar sync commented on June 2, 2024

@tamagui+portal+1.97.1.patch.zip

you can use this patch with patch-package

from tamagui.

nicolasartman avatar nicolasartman commented on June 2, 2024

Amazing, thank you so much @sync! I yarn-patched those lines out and builds are working again for me.

from tamagui.

kvaster avatar kvaster commented on June 2, 2024

I've tried this patch, but it doesn't work for me :(

I'm having this error on Android build:

 (NOBRIDGE) ERROR  TypeError: Cannot read property 'add' of undefined

This error is located at:
    in PortalHostComponent (created by PortalProviderComponent)
    in PortalProviderComponent (created by TamaguiProvider)
    in Theme (created by ThemeProvider)
    in ThemeProvider (created by TamaguiProvider)
    in Provider (created by TamaguiProvider)
    in TamaguiProvider (created by TamaguiProvider)
    in TamaguiProvider (created by Application)
    in Application (created by _default)
    in _default
    in Unknown (created by Route())
    in Suspense (created by Route())
    in Route (created by Route())
    in Route() (created by ContextNavigator)
    in RNCSafeAreaProvider (created by SafeAreaProvider)
    in SafeAreaProvider (created by wrapper)
    in wrapper (created by ContextNavigator)
    in EnsureSingleNavigator
    in BaseNavigationContainer
    in ThemeProvider
    in NavigationContainerInner (created by ContextNavigator)
    in ContextNavigator (created by ExpoRoot)
    in ExpoRoot (created by App)
    in App (created by ErrorOverlay)
    in ErrorToastContainer (created by ErrorOverlay)
    in ErrorOverlay (created by withDevTools(ErrorOverlay))
    in withDevTools(ErrorOverlay)
    in RCTView (created by View)
    in View (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer
    in main(RootComponent)

from tamagui.

natew avatar natew commented on June 2, 2024

Have a fix in main for this will get it out today. Wonder why transition would break it, weird?

from tamagui.

sync avatar sync commented on June 2, 2024

weird indeed

from tamagui.

kvaster avatar kvaster commented on June 2, 2024

For me the problem is still there, but in another place:

 (NOBRIDGE) ERROR  TypeError: Cannot read property 'add' of undefined

This error is located at:
    in Unknown (created by Themed(Anonymous))
    in Theme (created by Themed(Anonymous))
    in Themed(Anonymous)
    in Unknown
    in Unknown (created by Screen)
    in Screen (created by _default)
    in AppLoader (created by _default)
    in RNGestureHandlerRootView (created by GestureHandlerRootView)
    in GestureHandlerRootView (created by Application)
    in RNCSafeAreaProvider (created by SafeAreaProvider)
    in SafeAreaProvider (created by Application)
    in PortalProviderComponent (created by TamaguiProvider)
    in Theme (created by ThemeProvider)
    in ThemeProvider (created by TamaguiProvider)
    in Provider (created by TamaguiProvider)
    in TamaguiProvider (created by TamaguiProvider)
    in TamaguiProvider (created by Application)
    in Application (created by _default)
    in _default
    in Unknown (created by Route())
    in Suspense (created by Route())
    in Route (created by Route())
    in Route() (created by ContextNavigator)
    in RNCSafeAreaProvider (created by SafeAreaProvider)
    in SafeAreaProvider (created by wrapper)
    in wrapper (created by ContextNavigator)
    in EnsureSingleNavigator
    in BaseNavigationContainer
    in ThemeProvider
    in NavigationContainerInner (created by ContextNavigator)
    in ContextNavigator (created by ExpoRoot)
    in ExpoRoot (created by App)
    in App (created by ErrorOverlay)
    in ErrorToastContainer (created by ErrorOverlay)
    in ErrorOverlay (created by withDevTools(ErrorOverlay))
    in withDevTools(ErrorOverlay)
    in RCTView (created by View)
    in View (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer
    in main(RootComponent)

from tamagui.

contactsimonwilson avatar contactsimonwilson commented on June 2, 2024

@kvaster same here

For me it seems to be breaking on any use of the Switch component

from tamagui.

sync avatar sync commented on June 2, 2024

yes @kvaster, @natew it is once more startTransition messing things, can reproduce on touch if Switch component is enabled:

this code:

      const [checked, setChecked] = useControllableState({
        prop: checkedProp,
        defaultProp: defaultChecked || false,
        onChange: onCheckedChange,
        transition: true,
      })

can be fixed if changed to:

      const [checked, setChecked] = useControllableState({
        prop: checkedProp,
        defaultProp: defaultChecked || false,
        onChange: onCheckedChange,
        transition: false,
      });

There is really something funky with startTransition happening somewhere.

from tamagui.

sync avatar sync commented on June 2, 2024

Probably one of the .add in there https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Renderer/implementations/ReactFabric-prod.js or the dev one: Libraries/Renderer/implementations/ReactFabric-dev.js

from tamagui.

sync avatar sync commented on June 2, 2024

crashing here inside the dev renderer

Screenshot 2024-05-15 at 8 37 18 PM

from tamagui.

sync avatar sync commented on June 2, 2024

Just a temp fix but you can patch the renderer

react-native+0.74.1.patch.zip

from tamagui.

sync avatar sync commented on June 2, 2024

Will look at upstreaming this inside rn if it makes sense and then we should be fine with startTransition

from tamagui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.