Comments (16)
We experiancing same problem with tamagui and 'PortalHostComponent' when trying to migrate to new architecture.
from tamagui.
Fixed in https://github.com/tamagui/tamagui/releases/tag/v1.98.0
from tamagui.
pr here: facebook/react-native#44586
from tamagui.
you can temporarily fix it by patching this file:
node_modules/@tamagui/portal/dist/cjs/GorhomPortal.native.js
And change this method on line 182:
from
var next = function(value) {
(0, import_react.startTransition)(function() {
dispatch(value);
});
};
to
var next = function(value) {
dispatch(value);
};
from tamagui.
@tamagui+portal+1.97.1.patch.zip
you can use this patch with patch-package
from tamagui.
Amazing, thank you so much @sync! I yarn-patched those lines out and builds are working again for me.
from tamagui.
I've tried this patch, but it doesn't work for me :(
I'm having this error on Android build:
(NOBRIDGE) ERROR TypeError: Cannot read property 'add' of undefined
This error is located at:
in PortalHostComponent (created by PortalProviderComponent)
in PortalProviderComponent (created by TamaguiProvider)
in Theme (created by ThemeProvider)
in ThemeProvider (created by TamaguiProvider)
in Provider (created by TamaguiProvider)
in TamaguiProvider (created by TamaguiProvider)
in TamaguiProvider (created by Application)
in Application (created by _default)
in _default
in Unknown (created by Route())
in Suspense (created by Route())
in Route (created by Route())
in Route() (created by ContextNavigator)
in RNCSafeAreaProvider (created by SafeAreaProvider)
in SafeAreaProvider (created by wrapper)
in wrapper (created by ContextNavigator)
in EnsureSingleNavigator
in BaseNavigationContainer
in ThemeProvider
in NavigationContainerInner (created by ContextNavigator)
in ContextNavigator (created by ExpoRoot)
in ExpoRoot (created by App)
in App (created by ErrorOverlay)
in ErrorToastContainer (created by ErrorOverlay)
in ErrorOverlay (created by withDevTools(ErrorOverlay))
in withDevTools(ErrorOverlay)
in RCTView (created by View)
in View (created by AppContainer)
in RCTView (created by View)
in View (created by AppContainer)
in AppContainer
in main(RootComponent)
from tamagui.
Have a fix in main for this will get it out today. Wonder why transition would break it, weird?
from tamagui.
weird indeed
from tamagui.
For me the problem is still there, but in another place:
(NOBRIDGE) ERROR TypeError: Cannot read property 'add' of undefined
This error is located at:
in Unknown (created by Themed(Anonymous))
in Theme (created by Themed(Anonymous))
in Themed(Anonymous)
in Unknown
in Unknown (created by Screen)
in Screen (created by _default)
in AppLoader (created by _default)
in RNGestureHandlerRootView (created by GestureHandlerRootView)
in GestureHandlerRootView (created by Application)
in RNCSafeAreaProvider (created by SafeAreaProvider)
in SafeAreaProvider (created by Application)
in PortalProviderComponent (created by TamaguiProvider)
in Theme (created by ThemeProvider)
in ThemeProvider (created by TamaguiProvider)
in Provider (created by TamaguiProvider)
in TamaguiProvider (created by TamaguiProvider)
in TamaguiProvider (created by Application)
in Application (created by _default)
in _default
in Unknown (created by Route())
in Suspense (created by Route())
in Route (created by Route())
in Route() (created by ContextNavigator)
in RNCSafeAreaProvider (created by SafeAreaProvider)
in SafeAreaProvider (created by wrapper)
in wrapper (created by ContextNavigator)
in EnsureSingleNavigator
in BaseNavigationContainer
in ThemeProvider
in NavigationContainerInner (created by ContextNavigator)
in ContextNavigator (created by ExpoRoot)
in ExpoRoot (created by App)
in App (created by ErrorOverlay)
in ErrorToastContainer (created by ErrorOverlay)
in ErrorOverlay (created by withDevTools(ErrorOverlay))
in withDevTools(ErrorOverlay)
in RCTView (created by View)
in View (created by AppContainer)
in RCTView (created by View)
in View (created by AppContainer)
in AppContainer
in main(RootComponent)
from tamagui.
@kvaster same here
For me it seems to be breaking on any use of the Switch component
from tamagui.
yes @kvaster, @natew it is once more startTransition messing things, can reproduce on touch if Switch component is enabled:
this code:
const [checked, setChecked] = useControllableState({
prop: checkedProp,
defaultProp: defaultChecked || false,
onChange: onCheckedChange,
transition: true,
})
can be fixed if changed to:
const [checked, setChecked] = useControllableState({
prop: checkedProp,
defaultProp: defaultChecked || false,
onChange: onCheckedChange,
transition: false,
});
There is really something funky with startTransition
happening somewhere.
from tamagui.
Probably one of the .add
in there https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Renderer/implementations/ReactFabric-prod.js or the dev one: Libraries/Renderer/implementations/ReactFabric-dev.js
from tamagui.
crashing here inside the dev renderer
from tamagui.
Just a temp fix but you can patch the renderer
from tamagui.
Will look at upstreaming this inside rn if it makes sense and then we should be fine with startTransition
from tamagui.
Related Issues (20)
- DatePicker on mobile HOT 2
- Can't upgrade to expo 50 HOT 1
- Tamagui class font weights broken when upgrading to Expo 51 HOT 1
- [Documentation] Changing package manager does not change the command on other code block HOT 3
- [Feature request] Wrap Burnt alerts
- Please Update lucide icon version
- Why can't the website open? HOT 2
- SVG tags being wrapped HOT 4
- Render Error: Cannot read property 'state' of undefined HOT 1
- [Bug] Select Trigger causes submission when inside a form (Web)
- Enter animations don't work with CSS HOT 1
- Datepicker Bento Component Error Android Only HOT 1
- @tamagui/constants esm build is missing platform-specific .mjs files HOT 8
- Error when build application with animations-moti HOT 3
- Button pressStyle stuck on after first press HOT 1
- Cannot find module 'react-dom' from Tamagui 1.97.0 in bare React Native HOT 2
- Why does TamaGUI has so big slowdown in performance? HOT 2
- Input component Errors out on React Native: Cannot read property useRef of null HOT 11
- screen will flash when too fast to toggle two dialog.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tamagui.