Giter Club home page Giter Club logo

Comments (8)

TalbotGooday avatar TalbotGooday commented on August 27, 2024 3

Merged, fixed, released. Version 3.1.0-beta.3 is waiting for you

from androidpdfviewer.

TalbotGooday avatar TalbotGooday commented on August 27, 2024 2

@madmas Thank you) I'll try to make a release ASAP)

from androidpdfviewer.

madmas avatar madmas commented on August 27, 2024 1

@TalbotGooday thanks a lot, works now.

from androidpdfviewer.

madmas avatar madmas commented on August 27, 2024

@TalbotGooday Thank a lot for the suggestion, I treid to patch it as well but inserted

 if(renderingHandlerThread == null){
            renderingHandlerThread = new HandlerThread("PDF renderer");
        }

instead of a return to re-initialize it as it is initialized in the constructor.
I was able to verify it in the context the error occured for me and it worked fine - do you want a PR for it or do you have thoughts about it?

from androidpdfviewer.

TalbotGooday avatar TalbotGooday commented on August 27, 2024

@madmas Please, create a PR. I can't fix this now 'cause I want to refactor the library on which based this one. I need some time to figure out how to build native code)

from androidpdfviewer.

madmas avatar madmas commented on August 27, 2024

@TalbotGooday here it is ;-) I would be great if you can forge a release after it is merged 😇

from androidpdfviewer.

madmas avatar madmas commented on August 27, 2024

@TalbotGooday it looks to me like something went wrong with the release :( I cannot get it from https://jitpack.io/com/github/TalbotGooday/AndroidPdfViewer/3.1.0-beta.3/ - does it work for you?

from androidpdfviewer.

TalbotGooday avatar TalbotGooday commented on August 27, 2024

@madmas Yeah. There was some kind of a bug with the jitpack. Try again now

from androidpdfviewer.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.