Giter Club home page Giter Club logo

Comments (2)

takuseno avatar takuseno commented on June 27, 2024 1

@zxp567 Hi, thank you for your request. I'm sure this can be supported in d3rlpy. I'm currently working on the next major update release in nightly branch. I might support Cal-CQL there.

from d3rlpy.

zxp567 avatar zxp567 commented on June 27, 2024

The Cal-QL code has been released by the author: https://github.com/nakamotoo/Cal-QL/.
However, it was implemented in JAXCQL and seems more robotics oriented, while I would just need something simpler that work with an offline MDPDataset like this d3rlpy library offers, and I am looking for discrete actions only as well.

Would you have some capacity to include the calculation of reference policy Q-values and the logic of cal-ql could be added to this repo's discreteCQL algorithm?

It seems we only need to revise "_compute_conservative_loss" in "algos/torch/cql_impl.py" by:

  1. adding the "return_to_go" similar to the calculation as in "https://github.com/nakamotoo/Cal-QL/blob/main/JaxCQL/replay_buffer.py" as another input;
  2. and including the lower bound logic similar to the logic as in "https://github.com/nakamotoo/Cal-QL/blob/main/JaxCQL/conservative_sac.py"

Right? Would be helpful if you could add this into this repo as Cal-QL seems to work significantly better than CQL once the online fine-tuning begins.

Thank you very much.

from d3rlpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.