Giter Club home page Giter Club logo

Comments (9)

zachaysan avatar zachaysan commented on June 22, 2024 1

There are some failing tests, yeah. From my vantage point it looks like ActiveRecord has some poorly generated SQL after the latest refactor, so I'm inclined to wait it out and hope it fixes itself. But if you'd like to try your own hand at it, it's a pretty easy repo to get the tests running in, though you do need sudo in order to create the test db.

from activerecord-hierarchical_query.

zachaysan avatar zachaysan commented on June 22, 2024 1

@mkamensky I think I have a fix ready here. I'm going cut a gem. Let me know if there are problems in your test suite.

from activerecord-hierarchical_query.

zachaysan avatar zachaysan commented on June 22, 2024 1

Ah, gotcha. Thanks for the PR @anfinil I've cut the new gem let me know if there are any problems.

from activerecord-hierarchical_query.

zachaysan avatar zachaysan commented on June 22, 2024

Ok latest Gem has a fix for Rails 6 support, let me know if there are any other issues.

from activerecord-hierarchical_query.

mkamensky avatar mkamensky commented on June 22, 2024

Thank you!

from activerecord-hierarchical_query.

mkamensky avatar mkamensky commented on June 22, 2024

Now 6.0.1 is here...

from activerecord-hierarchical_query.

zachaysan avatar zachaysan commented on June 22, 2024

What's the issue @mkamensky ?

from activerecord-hierarchical_query.

anfinil avatar anfinil commented on June 22, 2024

#28 fixes it

from activerecord-hierarchical_query.

mkamensky avatar mkamensky commented on June 22, 2024

Thanks, for the issue was simply that rails 6.0.1 is incompatible with the latest version, bundle was pulling an old one.

from activerecord-hierarchical_query.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.