Deadlock when sending some data in onConnected event about nv-websocket-client HOT 10 CLOSED

Are you using the latest version (1.22)?

from nv-websocket-client.

This one was caused on 1.16. Did you change something?

from nv-websocket-client.

1.16 was the version where I fixed a deadlock bug. Hmm... I must investigate the issue. Thank you for your report.

from nv-websocket-client.

Deadlock in 1.16 was reported by me in #21. It's definitely another issue.

Seems that I found the reason of this. In my case I'm sending a lot of data in onConnected callback. I'm using your library with congestion control enables. It means that frame queue size is limited. Deadlock happens If the number of messages submitted in onConnected callback > frame queue size and onConnected callback is triggered by ReadingThread. The reason of this in synchronized (mThreadsLock) which doesn't allow to start WritingThread. ReadingThread waits until WritingThread get items from frame queue and WritingThread waits when ReadingThread unlock mThreadsLock mutex because it's not started. Deadlock

from nv-websocket-client.

@TakahikoKawasaki Could you provide any ETA? Sorry for pushing this but I'm under pressure with this ticket and if it takes some time to fix on websocket-library level then I will implement a workaround on application level.

from nv-websocket-client.

Sorry, I'll look into the issue. Probably, I'll be able to update the code soon.

from nv-websocket-client.

@avasenin Try the new version, 1.23. If the issue still happens even with the new version, let me know again.

from nv-websocket-client.

Thx, I will check it tomorrow.

from nv-websocket-client.

Works great. Thanks

from nv-websocket-client.

@TakahikoKawasaki I'm wondering why you don't use https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/BlockingQueue.html? Would drop the need of synchronized.

from nv-websocket-client.