Comments (7)
@TakahikoKawasaki
So did you think about it since that day? 😉
AFAIK these lines
// It won't happen unless the programmer dare call // open() and disconnect() in parallel.
are not true because there's also async open method, and there are very valid reasons to do disconnect call while the connection is still opening — for example if user decided to abort the action which required the WS connection, and the only logical thing to do at this point is to terminate the WS connection. And it could be in "opening" state at this moment, if the user is sufficiently fast or the network is sufficiently slow.
from nv-websocket-client.
Isn't WebSocketFactory.setConnectionTimeout(int)
applicable to your case?
from nv-websocket-client.
Not in this case, because sometimes I have to immediately shut down all connections in response to other input.
from nv-websocket-client.
Calling close()
on the raw socket closes the raw socket. What does "sometimes doesn't (work)" mean? What do you expect to happen after close()
? I'm sorry I don't understand well what behavior you expect yet.
from nv-websocket-client.
Ah, sorry, when calling close(), the WebSocket object will sometimes continue to open (perhaps the socket hasn't been opened yet), and sometimes will fail to send a CLOSING and CLOSED state.
from nv-websocket-client.
Thank you. I understood what you meant. Give me some time to think about it.
from nv-websocket-client.
Any progress on this?
Why can't we close the connection while the state is CONNECTING
? Is there any reason I don't understand yet?
UPDATE 14/12/2022:
This is a workaround until this issue fixed. I think the correct implementation would be sending close signal to the polling thread, so that it can stop itself whenever it is convenient.
private lateinit var mClient: WebSocket
...
fun close() {
val client = mClient;
CoroutineScope(Dispatchers.IO).launch {
while (client.state == WebSocketState.CONNECTING) {
delay(10)
}
client.disconnect()
}
}
from nv-websocket-client.
Related Issues (20)
- getting below when i try subscribe my payload from Server sometimes
- getting below errors after socket opened and when i try to subscribe my payload from Server sometimes HOT 3
- why getListenerManager() getStateManager() and others are private ? HOT 1
- Denied app upload to PlayStore HOT 3
- How can I have a listener for each sendText Method? HOT 1
- Very misleading error message if jdk.crypto.ec module is missing
- NV WebSocket Client & Quarkus & GraalVM Native Image Problems HOT 1
- Race between WebSocketAdapter.onConnected() and .onTextMessage().
- websocket client send performance
- While multiple send, download is blocked
- -
- Crashes on API < 24 with new AGP that is needed for API 33 HOT 8
- Websocket disconnects automatically after 30 seconds HOT 3
- Handshake failure with basic Authorization
- Websocket makes two connections HOT 1
- how to get session id to send messages
- Throws Exception even if the url is valid
- Does the library use some Tracking link?
- Upgrade SHA-1 to SHA-256 in HandshakeReader
- Ability to replace threads
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nv-websocket-client.