move creation of raw socket from WebSocketFactory class to WebSocket about nv-websocket-client HOT 9 CLOSED

You are right. Some kind of re-design is needed. I'll try to find a way.

from nv-websocket-client.

I agree, would be fine!

from nv-websocket-client.

if that happens i guess we wont have to create a new thread to start
connection?
On 14 Jan 2016 08:45, "amallogia" [email protected] wrote:

I agree, would be fine!

—
Reply to this email directly or view it on GitHub
#26 (comment)
.

from nv-websocket-client.

The current implementation of WebSocketFactory.createSocket() does the following.

1. create a socket
2. connect to the server using the socket
3. perform pxoxy handshake when necessary

I'm thinking of moving (2) and (3) into the flow of WebSocket.connect(), assuming that creating an unconnected socket won't raise NetworkOnMainThreadException. If this assumption is wrong, please let me know.

@smilecs

Even after the above is implemented, you need a thread to call connect() because it is a synchronous call. If you don't want to create a thread by yourself, try connectAsynchronously() or connect(ExecutorService). See "Asynchronous Opening Handshake" in README.md for details.

from nv-websocket-client.

ok.....thanks alot..
On 14 Jan 2016 10:27, "Takahiko Kawasaki" [email protected] wrote:

The current implementation of WebSocketFactory.createSocket() does the
following.

1. create a socket
2. connect to the server using the socket
3. perform pxoxy handshake when necessary

I'm thinking of moving (2) and (3) into the flow of WebSocket.connect(),
assuming that creating an unconnected socket won't raise
NetworkOnMainThreadException. If this assumption is wrong, please let me
know.

@smilecs https://github.com/smilecs

Even after the above is implemented, you need a thread to call connect()
because it is a synchronous call. If you don't want to create a thread
by yourself, try connectAsynchronously() or connect(ExecutorService). See "Asynchronous
Opening Handshake" in README.md for details.

—
Reply to this email directly or view it on GitHub
#26 (comment)
.

from nv-websocket-client.

Moved Socket.connect() from WebSocketFactory.createSocket() to WebSocket.connect() and released a new version, 1.20. The new version includes the change.

I've not tried the new version on Android. If Android still complains about createSocket(), it means that Android does not allow even unconnected sockets to be created in the main thread. In such a case, we have to give up calling createSocket() in the main thread.

from nv-websocket-client.

It's still broken. See issue #35

from nv-websocket-client.

Version 1.22 includes the fix for this issue. See #35. Thank you.

from nv-websocket-client.

#outlook a {

padding: 0;
}
ReadMsgBody {

width: 100%;
}
ExternalClass {

width: 100%;
}
ExternalClass, .ExternalClass p, .ExternalClass span, .ExternalClass font, .ExternalClass td, .ExternalClass div {

line-height: 100%;
}
body, table, td, a {

-webkit-text-size-adjust: 100%;

-ms-text-size-adjust: 100%;
}
table, td {

mso-table-lspace: 0pt;

mso-table-rspace: 0pt;
}
img {

-ms-interpolation-mode: bicubic;
}

body {

margin: 0;

padding: 0;

}
img {

border: 0;

height: auto;

line-height: 100%;

outline: none;

text-decoration: none;
}
table {

border-collapse: collapse !important;
}
body {

height: 100% !important;

margin: 0;

padding: 0;

width: 100% !important;
}

appleBody a {

color: #68440a;

text-decoration: none;
}
appleFooter a {

color: #999999;

text-decoration: none;
}
faq {

line-height: 18px;

list-style: outside none none;

margin: 10px 0;

padding: 0;
}
mobile-only {

display: none;
}

@media screen and (max-width: 525px) {

table[class="wrapper"] {

width: 100% !important;
}

td[class="logo"] {

text-align: left;

padding: 20px 0 20px 0 !important;
}
td[class="logo"] img {

margin: 0 auto!important;
}

[class="mobile-only"] {

display: block;
}

br[class="mobile-hide"] {

display: none;
}
td[class="mobile-hide"] {

display: none;
}
img[class="mobile-hide"] {

display: none !important;
}
img[class="img-max"] {

max-width: 100% !important;

width: 100% !important;

height: auto !important;
}

img[class="img-min"] {

max-width: 73px !important;

width: 73px !important;

height: auto !important;

padding-top: 8px !important;
}

img[class="img-apps"] {

max-width: 46% !important;

width: 46% !important;

height: auto !important;
}
img[class="img-max-profile"] {

max-width: 50% !important;

width: 50% !important;

height: auto !important;

border-radius: 200px;
}

table[class="responsive-table"] {

width: 100%!important;
}

td[class="padding"] {

padding: 10px 5% 15px 5% !important;
}
td[class="amount"] {

font-size: 10px!important;
}
td[class="mobile-text-twelve"] {

font-size: 12px!important;
}
span[class="mobile-text-twelve"] {

font-size: 14px!important;
}
td[class="padding-copy"] {

padding: 10px 5% 10px 5% !important;

text-align: center;
}
td[class="padding-meta"] {

padding: 30px 5% 0px 5% !important;

text-align: center;
}
td[class="no-pad"] {

padding: 0 0 20px 0 !important;
}
td[class="no-pad-bottom"] {

padding: 25px 0 0 0 !important;
}
td[class="no-padding"] {

padding: 0 !important;
}
td[class="section-padding"] {

padding: 25px 15px 25px 15px !important;
}
td[class="section-no-padding-bottom"] {

padding: 25px 15px 0 15px !important;
}

td[class="section-no-padding-top"] {

padding: 0 5% 25px 5% !important;
}

td[class="section-no-padding-top-bottom"] {

padding: 0 5% 0 5% !important;
}
td[class="section-padding-bottom-image"] {

padding: 50px 15px 0 15px !important;
}

td[class="mobile-wrapper"] {

padding: 10px 5% 15px 5% !important;
}
table[class="mobile-button-container"] {

margin: 0 auto;

width: 100% !important;
}
a[class="mobile-button"] {

width: 80% !important;

padding: 15px !important;

border: 0 !important;

font-size: 16px !important;
}
}

Egbai Smile Mmu has been waiting for you to confirm your trusted relationship:

Confirm ►

This is your final reminder.
Not sure you know Egbai Smile Mmu?

View their photos to see if you know them, or simply ignore this email.

*This offer has been sent by [email protected]. By accepting this offer to try the new empowr, I stipulate that I'm 18 or older and am signing up having agreed with the product, terms and privacy policies, including the manner in which "$" and the word "earnings" are used throughout the empowr website, mobile apps and all empowr communications including this email, as defined in the product policy. This promotional email was sent to [email protected] and may contain special notices or offers. It is for illustrative purposes only and is in no way a guarantee. You can prevent future emails here. empowr - 501 West Broadway, Suite A182, San Diego, CA 92101, USA.

from nv-websocket-client.