Comments (2)
this.refs.portal.closePortal()
This is bad design and it will break with React 0.14 since refs will return underlying DOM nodes and not React components anymore.
There are two other and better ways:
Put
<div onClick={function () { }}> // it works without the handler
<button ref="close" type="button" onClick={this.handleClose}>Close</button>
</div>
into a new component and then you can use
<button ref="close" type="button" onClick={this.props.closePortal}>Close</button>
or if you don't want to create a new component for some reason, you can use the prop isOpened
:
<span onClick={(function(e) {this.setState({isOpened: true})}).bind(this)}>
<Portal isOpened={this.state.isOpened}>
<div onClick={function () { }}> // should work now
<button ref="close" type="button" onClick={(function(e) {this.setState({isOpened: false})}).bind(this)}>Close</button>
</div>
</Portal>
I didn't test the code above, so I'm sorry for possible typos.
from react-portal.
Works perfectly, thanks!
This is bad design and it will break with React 0.14 since refs will return underlying DOM nodes and not React components anymore.
This only applies to native DOM components, not custom components:
As with refs, this change does not affect custom components (eg.
<MyFancyMenu>
or<MyContextProvider>
), which remain unaffected by this change.
from react-portal.
Related Issues (20)
- How to enable SSR of portaled content? HOT 9
- No umd bundle
- Support for react native HOT 2
- Add nodeID and nodeClassName props to Portal HOT 2
- Portal break when node=document.body
- can I render two elements in a portal? HOT 1
- Does not work with SSR HOT 11
- handleoutside not triggering on clicking the sibbling child element it open the both the menu item at once HOT 1
- closeOnOutsideClick does not work with reactstrap Modal component HOT 1
- Using state to conditionally render components causing PortalWithState modal to close when closeOnOutsideClick true HOT 2
- Portal closes when dragging from inside portal and releasing outside of portal
- [Feature Request] Optional prop to render only one child at a time
- closeOnOutSideClick triggered condition
- react-dom is not listed in peerDependencies HOT 3
- react-portal onOpen Not Firing
- openByClickOn Not Displaying The Button In v4
- demo page would be helpful
- Portal deprecated according to TS in VScode HOT 1
- Context information cannot be passed through the portal
- React 18 support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-portal.