Giter Club home page Giter Club logo

Comments (2)

tajo avatar tajo commented on August 25, 2024
this.refs.portal.closePortal()

This is bad design and it will break with React 0.14 since refs will return underlying DOM nodes and not React components anymore.

There are two other and better ways:

Put

<div onClick={function () { }}> // it works without the handler
  <button ref="close" type="button" onClick={this.handleClose}>Close</button>
</div>

into a new component and then you can use

<button ref="close" type="button" onClick={this.props.closePortal}>Close</button>

or if you don't want to create a new component for some reason, you can use the prop isOpened:

<span onClick={(function(e) {this.setState({isOpened: true})}).bind(this)}>
<Portal isOpened={this.state.isOpened}>
  <div onClick={function () { }}> // should work now
    <button ref="close" type="button" onClick={(function(e) {this.setState({isOpened: false})}).bind(this)}>Close</button>
  </div>
</Portal>

I didn't test the code above, so I'm sorry for possible typos.

from react-portal.

silvenon avatar silvenon commented on August 25, 2024

Works perfectly, thanks!

This is bad design and it will break with React 0.14 since refs will return underlying DOM nodes and not React components anymore.

This only applies to native DOM components, not custom components:

As with refs, this change does not affect custom components (eg. <MyFancyMenu> or <MyContextProvider>), which remain unaffected by this change.

from react-portal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.