Giter Club home page Giter Club logo

Comments (4)

tajo avatar tajo commented on August 25, 2024

Why do you need that? Why is not good enough to style just its child content? (You are asking about the empty div that is dynamically appended to the document.body, right?)

from react-portal.

Zenwolf avatar Zenwolf commented on August 25, 2024

One example is if a web application has some general styles that apply to all HTML elements, such as position: relative which is generally desired except in special circumstances. One special circumstance is a modal dialog. The child Portal content cannot escape from its positioned parent, which may inherit positioning from generic CSS. In this case, being able to apply a style makes it much easier to make the modal behavior of absolutely positioning the portal content across the entire screen. Does that make sense?

from react-portal.

tajo avatar tajo commented on August 25, 2024

Oh, that's a very valid point.

Is it good enough to add a CSS class (e.g react-portal) to the portal root element? I believe React inline styles (and passing them as an another prop) can't be used since the portal root div is created out of React's scope. It would be nice to achieve that though (any idea how?). Will you send a PR?

from react-portal.

tajo avatar tajo commented on August 25, 2024

Is there a way to set a className on the Portal

Or this. It's more explicit for users, therefore better.

from react-portal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.