304 response status codes trigger the on_failure block about curb HOT 9 CLOSED

Hi Wes,

Sorry for the long delay... This really comes down to a deficiency in the current callback interface, whether we say 20x is success or 30x is failure just means we really can't easily classify response codes binary as success or failure... I suggest using the on_complete callback...

from curb.

No worries. I ended up implementing using the on_complete callback and having it check in the on_failure callback to ignore if it was a 304 response code.

from curb.

Maybe for future releases the right thing to do here would be to add a on_redirect, and on_missing callback?

from curb.

Thats a good idea. Maybe define the set callbacks more specific for the various status response groups:
2xx codes on_success
3xx codes on_redirect
4xx codes on_missing
5xx codes on _failure

One thing that might get somewhat confusing is that network connection, DNS failed lookups, and 5xx reponse codes are getting grouped in on_failure callback. Not sure if you want to break those out in a separate ones or not.

Another possible solution is to add callbacks for each of the response status codes - on_200, on_301, on_404. This way the developer can be very specific as to how they want to handle each of the status codes.

from curb.

Okay, I'm thinking something such as. easy.on("304") {|c| ... } etc... There is a bit of overhead in this but I think it's not huge. Will update as I make progress

from curb.

Any updates on this? Thanks.

from curb.

will work on this for the 0.8 series... porting more c code to ruby will make this kind of interface easier to implement.

from curb.

Awesome, Todd! Thank you!

from curb.

for 0.8 release on_redirect and on_missing will be included in addition to on_success, on_failure and on_complete.

from curb.