Comments (9)
This is a good approach and if this can be adopted it would help tremendously.
Thanks for suggesting.
from t3.
Currently, the core theme is put in folder "base" in the plugin. We should provide multiple core theme feature as an addon package of the plugin. IMO, the feature could be implemented as:
- upload a base theme to folder plugins/system/t3/newbase
- declare the new base theme in templateDetails.xml
<fieldset name="general_params" label="T3_GENERAL_LABEL" description="T3_GENERAL_DESC">
<field name="coretheme" type="hidden" default="newbase" />
</fieldset>
How do you think about this approach ?
from t3.
The issue is the template overrides.
I think there should be a plugin inside to allow override of overrides or not, when updating the framework.
from t3.
The framework provides only default base theme. Developers can provide their own base themes and declare to use it in template. Therefore, when upgrading framework, their work is not lost.
from t3.
I like this idea but I guess as soon as folks start adding their own overrides to the plugin then they are technically forking the plugin and potentially need to update each time the install an update for the plugin. There would be a way to not touch the new overrides when installing the plugin but seems better to move the override fiels outside of the plugin all together.
Perhaps we could check the media folder for possible overrides? So these are just folders that get uploaded to media/t3/ and the plugin checks there before it checks the plugin?
Perhaps the priority should be:
- template
- media
- plugin
What do you think?
from t3.
I think this approach could work.
from t3.
Either approach works for me.
from t3.
@locii : the new overrides are not part of T3, therefore it will not be overridden when upgrade the plugin. However, put it in media folder is a good idea. We may allow developers add their own override name so we can have multiple overrides on the same site.
from t3.
The feature has been implemented in T3 1.2.0 now. New HTML base is put in media/t3/themes/[name] and declare in templateDetails.xml as:
<t3>
<base>[name]</base>
</t3>
from t3.
Related Issues (20)
- Error updating COM_INSTALLER_TYPE_TYPE_. HOT 1
- Manifest file missing: Can not uninstall T3 Framework Package
- About 1 px Left Padding issue
- Joomla 3.9 Update
- Front end edit button is not loading on article page when change Position of Article Info HOT 1
- T3 framework v2.7.3 has an error when used with PHP 7.3.0
- Can not show privacy content on popup in RTL language
- Can not show privacy link on registration page and user profile page
- Got warning error when enable dev mode HOT 1
- off canvas menu does not close when clicking outside menu on mobile safari on iOS HOT 1
- PHP Warning in /plugins/system/t3/includes/menu/t3bootstrap.php HOT 1
- Custom code section not working
- overwrite joomla core file
- joomlart.com is down...4 days
- Can't access T3 templates in com_templates: Cannot use object of type TemplatesViewStyle as array HOT 2
- missing module titles when placed with loadposition in article since T3 system plugin version 3.0.0 up to current 3.0.3 HOT 4
- t3 framework plugin since version 3.0.0 does not override mod_menu anymore
- megamenurender.php:36 issue after upgrading to PHP8
- Version 3.1.3 update
- Glossary bug in 3.2.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from t3.