Giter Club home page Giter Club logo

Comments (9)

raramuridesign avatar raramuridesign commented on July 20, 2024

This is a good approach and if this can be adopted it would help tremendously.
Thanks for suggesting.

from t3.

joomlart avatar joomlart commented on July 20, 2024

Currently, the core theme is put in folder "base" in the plugin. We should provide multiple core theme feature as an addon package of the plugin. IMO, the feature could be implemented as:

  1. upload a base theme to folder plugins/system/t3/newbase
  2. declare the new base theme in templateDetails.xml

<fieldset name="general_params" label="T3_GENERAL_LABEL" description="T3_GENERAL_DESC">
    <field name="coretheme" type="hidden" default="newbase" />
</fieldset>

How do you think about this approach ?

from t3.

raramuridesign avatar raramuridesign commented on July 20, 2024

The issue is the template overrides.
I think there should be a plugin inside to allow override of overrides or not, when updating the framework.

from t3.

joomlart avatar joomlart commented on July 20, 2024

The framework provides only default base theme. Developers can provide their own base themes and declare to use it in template. Therefore, when upgrading framework, their work is not lost.

from t3.

locii avatar locii commented on July 20, 2024

I like this idea but I guess as soon as folks start adding their own overrides to the plugin then they are technically forking the plugin and potentially need to update each time the install an update for the plugin. There would be a way to not touch the new overrides when installing the plugin but seems better to move the override fiels outside of the plugin all together.

Perhaps we could check the media folder for possible overrides? So these are just folders that get uploaded to media/t3/ and the plugin checks there before it checks the plugin?

Perhaps the priority should be:

  1. template
  2. media
  3. plugin

What do you think?

from t3.

raramuridesign avatar raramuridesign commented on July 20, 2024

I think this approach could work.

from t3.

ryanbelisle avatar ryanbelisle commented on July 20, 2024

Either approach works for me.

from t3.

joomlart avatar joomlart commented on July 20, 2024

@locii : the new overrides are not part of T3, therefore it will not be overridden when upgrade the plugin. However, put it in media folder is a good idea. We may allow developers add their own override name so we can have multiple overrides on the same site.

from t3.

joomlart avatar joomlart commented on July 20, 2024

The feature has been implemented in T3 1.2.0 now. New HTML base is put in media/t3/themes/[name] and declare in templateDetails.xml as:


<t3>
    <base>[name]</base>
</t3>

from t3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.