Giter Club home page Giter Club logo

Comments (4)

szabodanika avatar szabodanika commented on May 14, 2024 1

Seems like a good option to have and @henry40408 I am happy with you creating a PR for this, including using that library if it makes the URLs significantly shorter. The name for the new arg could be --hash-ids just to match the pattern we have with the rest.

I think the following would be the simplest way to implement this, but feel free to be more creative:

  1. create a second coverter hash_ids with hashids library with 2 functions to_u64 and to_hash in the same style as animalnumbers.rs
  2. create a third converter (e.g. id_converter) that also has 2 functions and calls either animalnumbers or the second converter based on the presence of the --hash-ids arg
  3. call this third converter everywhere where animalnumbers::to_u64 or animalnumbers::to_animal_names is called currently
  4. profit

I don't see us adding more numbering schemes in the future but if we want emoji-based ID's or whatever, it should be fairly simple to add it following this pattern

from microbin.

henry40408 avatar henry40408 commented on May 14, 2024 1

@szabodanika I have submitted a pull request. Please help review thanks.

from microbin.

Panja0 avatar Panja0 commented on May 14, 2024

I can relate to this as well.
So +1

from microbin.

henry40408 avatar henry40408 commented on May 14, 2024

hi @szabodanika I'd like to claim this issue and...

  • Use hashids since we need to serialize primary key to animal names and vice versa
  • Add a new option --hashids for user this feature and let animal names be the default

from microbin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.