Giter Club home page Giter Club logo

Comments (4)

syt0r avatar syt0r commented on August 15, 2024

I understand your concern, I myself sometimes intentionally make additional mistakes if I was able to guess character with few mistakes which is weird UX to trigger mistake. Unfortunatelly my stroke detection algorithm is not perfect and I often notice that there are false positive errors when writing small or complicated strokes, this is why I allowed to make up to 2 mistakes for writing practice, but 0 for reading. I'm thinking about how to make it more customizable alongside with #29 feature. My current idea is to add option to settings screen like SRS (Spaced repetition system) configuration that opens new screen where you can adjust:

  1. review intervals (now it's square root of days count with reviews without mistakes, I want to add a more options with example chart)
  2. separate toleranted mistakes count for writing and reading
  3. and maybe an option to make repeat button automatically be considered as mistake

On a second thought points 2 and 3 are not very flexible because configuration would be applied to all repeats automatically and can be replaced with additional button on practice screen but idk how to fit it into layout

The other idea would be not to save practice results automatically on summary screen, but to allow user to toggle characters that have mistakes and should be repeated next day

Quite a lot of options so I'm still thinking which is the best one 😅

from kanji-dojo.

kanji-deshi avatar kanji-deshi commented on August 15, 2024

Thanks for your detailed answer.

I'm still unsure how the current algorithm works. Let's say I draw a kanji with 2 mistakes and hit the red button. Then I draw it again with 1 mistake and hit the green button. Will the review period reset (because the total count of mistakes is higher than 2)? If so, I think all I need is a way to lower the limit for the green button to appear.

I think of this app as a(n actually pretty fun) game. However that also means that I never hit a red button unless I have to. I don't even keep track of how many mistakes I made so just having the count displayed somewhere while drawing would already help.

from kanji-dojo.

syt0r avatar syt0r commented on August 15, 2024

Sorry for late reply. Application counts total mistakes for a character, as shown in summary, more than 2 and red highlight means interval reset.

I think there is no need to lower limit for green button because you can always pick retry option yourself, right?

I'm thinking to stick to the option with manual selection of characters for which interval should be reseted on the summary screen, there it would be possibly to make adjustable mistakes count threshold for automatic preselection and further adjust selection manually. With this solution 2 buttons(repeat and next) can be shown all the time and it would be up to the user to decide whether to practice more or less, pretty flexible imho

from kanji-dojo.

kanji-deshi avatar kanji-deshi commented on August 15, 2024

Thanks for the clarification. Theoretically, I could always pick retry myself, I just don't want to make that decision every time. It's OK though, I managed to build my own version. (I changed CharacterMistakesToRepeat from WritingPracticeInputSection.kt)

from kanji-dojo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.