Giter Club home page Giter Club logo

Comments (3)

larixer avatar larixer commented on May 11, 2024 2

Hi Gilad,

Thank you for giving a try to this starter kit.

Maybe what you are really looking for is code-splitting based on React routes, so that some React routes, that don't use heavy stuff like Apollo or React Bootstrap didn't load these heavy dependencies and pulled only bare minimum needed? Like the way it is described here:
https://medium.com/@puppybits/webpack-code-splitting-by-routes-92f96cf733f2#.3zdulutcp
Well, we want not only code-splitting of the application code as described in the article above, but also code-splitting of vendor javascripts, so that we didn't load Apollo, React Bootstrap and other heavy stuff on "static" routes.

Yes, I think, that adding code-splitting support to this starter kit is a good idea and I will try to add this soon.

Victor

from apollo-universal-starter-kit.

GiladShoham avatar GiladShoham commented on May 11, 2024

Thanks for your quick response
Yes, code-splitting is my other thought about it.
I'm still thinking about which one is a better approach.
Anyway, also configure a code-splitting is not so easy with all the different configs (SSR, dev/prod, vendors splitting, plain CSS vs sass)
Also usually in the reality, a landing page will not use even react sometimes and not sass but only plain HTML/CSS with a script and some vendors script.
(Maybe the support should come in the form of a react component which use dangerouslySetInnerHTML to load the static HTML, in this case, it will support both react static page and HTML static page)
So a support for such case will be wonderfull.

By the way, what happen with code splitting when you make a client routing, like clicking on the logo to move to the landing page, because the splitting is on the server, and in client routing this mechanism won't run on the server, so somehow you have to load the additional required scripts. (I'm sure there is a solution for this, just wondering how it works)

Thanks again!

from apollo-universal-starter-kit.

larixer avatar larixer commented on May 11, 2024

This issue needs more clarification, what do we really want. Closing it for now.

from apollo-universal-starter-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.