support http healthcheck for api lb about cluster-api-provider-hetzner HOT 6 OPEN

@simonostendorf please elaborate a bit more in which use-case you encountered the error. What kind of cluster did you create, how many control-planes?

Do you have logs/events/conditions where the error is visible?

You propose to extend the CRD HetznerCluster, is that correct?

from cluster-api-provider-hetzner.

You propose to extend the CRD HetznerCluster, is that correct?

Yes.

please elaborate a bit more in which use-case you encountered the error. What kind of cluster did you create, how many control-planes?

I didn't get any errors as far as I can remember but I heard that other clusters (e.g. openstack) have problems at cluster updates where the api is unavailable because the lb adds the nodes before the api server is ready and I think to prevent errors like this and to use all the features provided by the hcloud lb, this should be added to the HetznerCluster as its a better check than tcp. I usually use 3 hcloud nodes as control plane.

from cluster-api-provider-hetzner.

I heard that other clusters (e.g. openstack) have problems at cluster updates where the api is unavailable because the lb adds the nodes before the api server is ready

@simonostendorf I hope that would be a problem here ;)

from cluster-api-provider-hetzner.

But what do you do if the apiserver becomes unhealthy later and the port is still reachable via tcp?

The initial problem is solved. I didn't check the code, sorry :)

from cluster-api-provider-hetzner.

@simonostendorf I don't have all the details in my mind. But overall the code is readable. Could you please have a look at the code?

If you don't understand the code, then please tell us! The code should be readable, if comments are missing, we want to add them.

Is that ok for you?

from cluster-api-provider-hetzner.

@guettli what would be your answer to this question here?

But what do you do if the apiserver becomes unhealthy later and the port is still reachable via tcp?

from cluster-api-provider-hetzner.