Comments (5)
zolkis
commented on August 16, 2024
Fixed.
from telephony.
marcoscaceres
commented on August 16, 2024
@zolkis please be sure to close bugs through pull requests. Otherwise, we don't have a record of what commit closed what bug. Please alway be sure that your pull requests are reviewed by at least one person (e.g., the person who filed the bug).
from telephony.
zolkis
commented on August 16, 2024
I have included the issue number and link to the commit comment. As I am the committer, I could file a pull request to myself, which I can do next time - or should I fork your repo, file a PR to you, then you'd file a PR to the committer (me)?
from telephony.
zolkis
commented on August 16, 2024
Actually, if we want to track issues, we must mention the issue number in the commit messages for sure, then of course we could also use pull requests and leaving time for review.
from telephony.
marcoscaceres
commented on August 16, 2024
The way I do it is:
- fork the repo from sysapps to my own space on GH.
- make changes.
- send PR back to sysapps. If the PR is closing some particular bug, I just say "potentially closes #X".
- wait for integrator (or others in the WG) to review - accept/reject.
- if accepted, then the bug addressed in the PR is also be closed.
So, yeah, mentioning the issue number is good because GH automagically associates them together.
from telephony.
Related Issues (20)
- argument params vanished with noLegacyStyle HOT 1
- Dial and telephone number format HOT 12
- Invoking dial() twice should result in an AbortError HOT 3
- Making outbound calls needs to be better defined HOT 3
- Dial method needs rewrite HOT 2
- calls attribute of the TelephonyManager interface should be a sequence HOT 3
- DialParams and ToneParams should be DialOptions, ToneOptions HOT 1
- dial() method needs to treat null as empty string HOT 2
- Add a TOC HOT 2
- Telephony system eventing model should fill event gaps
- serviceIds needs to be redefined as sequence
- emergencyNumbers needs to become a sequence
- Check that methods relying on promises must not throw synchronously
- Recommend a format for serviceID HOT 2
- Call waiting support on CDMA HOT 7
- consider using telephony service objects HOT 5
- MMI support in Telephony API HOT 2
- Notification when calls array is ready even it's empty HOT 2
- merge calls from different services/sim cards HOT 9
- support for call history sync HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from telephony.