LineOrder inverted about tinyexr HOT 6 CLOSED

Hello Andrew,

Oops, you are right. The output image from tinyexr looks correctly ordered, thus simply the comment is wrong.

And, PR is always welcome!

from tinyexr.

If I'm not misinterpreting it, ASCENDING_Y, which is 0, implies that the scanlines are stored top-to-bottom, correct? So I believe a line like this is reversed. As an aside, when I merged the commit that added the lineOrder parameter, all of my images flipped upside down. Am I just misreading all of this?

from tinyexr.

Am I just misreading all of this?

You looks correct.

extcat is a good tool to test result with OpenEXR,

https://github.com/syoyo/tinyexr/blob/51ab09c9b74a455c1fbb8d2bed80a7c9ff062c2a/test/exrcat/exrcat.cpp

And interestingly, when I run this with recent tinyexr code, the output become different(i.e. lineOrdering flipped)… although it reported identical result before. @mmp do you have any idea?

from tinyexr.

It looks like the inconsistency has been introduced here

8c7a865

So is it OK to invert lineOrder value, @mmp?

from tinyexr.

Oops, sorry about that. That fix looks good to me.

from tinyexr.

Oops, sorry about that. That fix looks good to me.

Thanks @mmp!

And now fixed the issue. lineOrder should now be correct! > @andrewfb

from tinyexr.