Giter Club home page Giter Club logo

Comments (7)

imsodin avatar imsodin commented on June 12, 2024 1

No need just sending a pr is fine and would be much appreciated.

from syncthing-android.

githubashutoshsoni avatar githubashutoshsoni commented on June 12, 2024 1

#1983 mostly fixes this issue with notification.

from syncthing-android.

imsodin avatar imsodin commented on June 12, 2024

Thanks for reporting this, especially during beta!

Seems like some new permission we need to specify/ask for: https://developer.android.com/develop/ui/views/notifications/notification-permission

Lovely how they mention notification behaviour changes in the target sdk 33 change guide, but fail to mention that this permission is new...
Edit: There's another guide about android 13 (not target sdk), and that one does mention the new permission. Looks like I should also closely follow every android releases behaviour changes (spoiler alert: I likely wont). Would be so nice if someone anyway doing android dev would join me as a co-maintainer - so little work, such a big impact (we have 6 digit users).

from syncthing-android.

githubashutoshsoni avatar githubashutoshsoni commented on June 12, 2024

Sure, I'm willing to take this up. @schlamar can you assign this to me?

from syncthing-android.

schlamar avatar schlamar commented on June 12, 2024

No, I'm just reporter.
@imsodin should do this.

from syncthing-android.

githubashutoshsoni avatar githubashutoshsoni commented on June 12, 2024

Great, @imsodin. I think I've added this and tested in android 13. Can you please verify?

from syncthing-android.

schlamar avatar schlamar commented on June 12, 2024

Can confirm that this was fixed in 1.26.0-rc.2

from syncthing-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.