Show a warning when users don't run the correct PHPUnit version about symfonydependencyinjectiontest HOT 13 CLOSED

@OskarStark Alas, if we require it directly, it will install the library as a project dependency.

from symfonydependencyinjectiontest.

One solution that could work might be to check for a class that was not present before PHPUnit 6 inside the setUp() method of the base test case class and skip the test otherwise.

from symfonydependencyinjectiontest.

@xabbuh that sounds good, but why not require it directly and IF someone like to use a .phar or a global installed version, it should work too, shouldn't it?

from symfonydependencyinjectiontest.

@xabbuh I'll see if there is something like a Version class, etc.

from symfonydependencyinjectiontest.

I guess this this error has to do with this?

PHPUnit 5.7.12 by Sebastian Bergmann and contributors.

PHP Fatal error:  Class 'PHPUnit\Framework\Constraint\Constraint' not found in /var/www/html/vendor/matthiasnoback/symfony-dependency-injection-test/PhpUnit/ContainerHasParameterConstraint.php on line 9

from symfonydependencyinjectiontest.

@lucasvanlierop It most likely does ;)

from symfonydependencyinjectiontest.

:-) Which version do you recommend?

from symfonydependencyinjectiontest.

@lucasvanlierop You could either use PHPUnit ^6.0 or switch to a previous major version of this library, e.g. 1.1.0.

from symfonydependencyinjectiontest.

Just did the latter thanks for confirming! Btw thanks for still maintaining this package! Used it a lot at Ibuildings and now I'm using it again for my new project ;-)

from symfonydependencyinjectiontest.

Cool, happy to hear that!

from symfonydependencyinjectiontest.

I've been thinking about this, but I can't come up with a good point to verify that the PHPUnit version used to run tests is the right one. The problem here is: I'd love to add this check to a setUp() method of some sorts, but the test runner crashes before it reaches this method, since it can't find the TestCase and related classes.
Anybody got another suggestion for this?

from symfonydependencyinjectiontest.

It would be nice if composer could check if a class is present (autoloadable) on install the same way it can check the presence of a php extension

from symfonydependencyinjectiontest.

Closing this as I don't think there will be a solution. I'm sure with this item in the issue archive people will quickly figure out what's wrong when they encounter this situation :)

from symfonydependencyinjectiontest.