Add support for testing if a extension still allows the container to be dumped about symfonydependencyinjectiontest HOT 7 CLOSED

@boekkooi Can you explain how your container looked like when you were not able to dump it?

from symfonydependencyinjectiontest.

A simple way to create a undumpable container is to set a instance as a service argument.
For example:

class MyExtension extends Extension
{
    /**
     * @inheritdoc
     */
    public function load(array $config, ContainerBuilder $container)
    {
....
        $def = new Definition('stdClass');
        $def->addArgument(new \stdClass());
        $container->setDefinition('test', $def);
....
    }
}

This has happened for example here boekkooi/tactician-amqp-bundle@af60508

from symfonydependencyinjectiontest.

I see, that's something that would indeed be caught by such a test. However, such a test would also fail under other circumnstances where you would not expect it or were it doesn't matter for your application. Ffor example, the YAML dumper does not support anonymous services (which is perfectly fine when dumping to PHP or XML).

from symfonydependencyinjectiontest.

Good point still maybe reworking the assert to accept the type of dumper would be a good idea then again nobody is forced to use the assert 😄 I was just wondering if creating a PR for this would be a good idea.

So make it something like protected function assertContainerCanBeDumpedAs($type = 'php')?

from symfonydependencyinjectiontest.

@boekkooi Thanks for bringing this up. However, as can be seen here: https://github.com/matthiasnoback/SymfonyDependencyInjectionTest/blob/master/PhpUnit/AbstractContainerBuilderTestCase.php#L18 the test scenario isn't a very realistic one so I doubt how much trust in an extension class this new assertion will bring us. If you want to be sure that a container can be dumped, you should create a test kernel and register your bundle as well as other bundles that are needed for successful execution. While booting that test kernel it will also be dumped to afaik PHP and XML (maybe in a temporary directory, but at least you will catch any exceptions caused by dumping it).

from symfonydependencyinjectiontest.

@matthiasnoback Thanks for the response. It was just a idea and you are correct a kernel would be the best solution. Thank you for taking the time!

from symfonydependencyinjectiontest.

@boekkooi Thanks for an interesting discussion! See you next time :)

from symfonydependencyinjectiontest.