Comments (3)
Interesting!
Yes it makes sense to fix that. If you find some time for a PR, that's much
appreciated. Even though I think that the ContainerBuilder should be fixed
as well ;)
Op 17 apr. 2015 14:24 schreef "Christian Flothmann" <
[email protected]>:
When writing tests for a legacy application, I discovered that the checks
performed in the ContainerBuilderHasAliasConstraint are not
case-insensitive.For example, take the following service definition and alias:
services:
fooBar:
class: \Foobar
foo:
alias: fooBarNotice the capitalised B in the service id for the fooBar service
definition. However, when using the assertContainerBuilderHasAlias(), you
will have to lowercase the service id. The reason is that the Symfony
DependencyInjection component lowercases all service ids and aliases.I suggest to reflect this behaviour in the
ContainerBuilderHasAliasConstraint and would be happy to open a pull
request for this. Though I first wanted to ask for your opinion on this.@matthiasnoback https://github.com/matthiasnoback What do you think?
—
Reply to this email directly or view it on GitHub
#39
.
from symfonydependencyinjectiontest.
See #40 for the fix.
@matthiasnoback I don't think that anything in the ContainerBuilder
needs to be fixed. Can you explain what you mean?
from symfonydependencyinjectiontest.
Of course, you're right. I misunderstood the problem.
from symfonydependencyinjectiontest.
Related Issues (20)
- failed to load vendor/autoload.php HOT 1
- LoaderFactory supporting .yaml extension
- Incompatibility with phpunit 8 HOT 2
- $container->getExtensionConfig() does not return minimal configuration
- Support for Symfony 5 HOT 3
- Assert container does not have a method call
- Lots of composer deprecation warnings about PSR-4 compliance HOT 2
- PHP8 Support HOT 1
- New release HOT 1
- False positive with assertContainerBuilderHasServiceDefinitionWithArgument
- Remove supported for Symfony 2.3 HOT 5
- Allow test DI-extenions that depends on another extensions and config
- it_lower_cases_aliased_service_ids fails HOT 2
- Next release HOT 1
- Add support for Symfony 4
- Investigate in build failure HOT 2
- Support tests for "Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface" HOT 1
- Add phpunit as a non-dev depedency. HOT 2
- 1.2.0 is not BC with 1.1.* HOT 3
- Declaration of Matthias\SymfonyDependencyInjectionTest\PhpUnit\DefinitionHasMethodCallConstraint::toString() must be compatible with PHPUnit\Framework\SelfDescribing::toString(): string
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from symfonydependencyinjectiontest.