look into adding lunetics/LocaleBundle for language detection about cmf-sandbox HOT 14 CLOSED

i looked over this together with dan. i agree that in the Multilang bundle we seem to partially duplicate the functionality of what he is doing. however, we think there is a fundamental philosophy clash between lunetics and what we think is right:

unless we misunderstood completely, the bundle does not use the _locale of the url but thinks that all languages are served under the exact same logic. i have seen this idea once or twice before from semantic web purists (the url is for the entity, the language is just different representation of content, language is negotiation). i think its wrong and it breaks with search engines and so on.

we could try to talk with the author and see if we understood correctly and if he would agree to make his bundle work with both situations though. and if not we could borrow some ideas from that bundle.

from cmf-sandbox.

i agree

from cmf-sandbox.

i sent the author an email

from cmf-sandbox.

For my POV, it will also need priorities preferences for the bundle itself. For e.g : You have an url like http://en.myapp.com/home/hello that you visit with a browser installed in French, which one to choose first or let the developer choose the one to choose in priority? it's a lot of choose....

from cmf-sandbox.

@Kwattro we should respect the browser supplied preferences. if none of that matches, we can just fallback on a default language. when loading content, we have another fallback order in phpcr-odm and there we could actually pimp a bit by reordering according to the browser settings.

i had a good chat with @lunetics yesterday. it turns out that the bundle for now just does not care about the _locale in the url, but there is no design decision to not have it. the bundle just does not assume any url scheme. he would be interested in pull requests to make the bundle more flexible. i think we want:

• allow to inject a service into the twig extension that renders the translation urls. that way we can directly link to the right translated content if we can determine it. or we can keep his redirection controller but add a url parameter to it, to still have the language choice cookie feature for the next visit.
• in our multilanguage route controller we no longer need to determine the locale but can get it from localeIdentified or rather use the service of LocaleBundle to determine the right language from our current choices.

anybody motivated to take this on? if i have to do it, it could take a while until i get to it...

from cmf-sandbox.

Yes it sounds logic but I was more thinking about it this morning as we actually need this implementation for another project.

As stated in the LocaleBundle, the User can change language manually, so the app cookie will contain the UserPrefered language that can be different from the browser language, so it is why I think it could be great to allow priorities in the bundle config 1->cookie 2->browser 3->url 4->fallback for other implementations of the bundle.

I set 1->cookie because for me this is part of USER preferences.

from cmf-sandbox.

Adding some kind of Priority sounds like a good idea (e.g. when you want to add GEOIP as fallback). Also would be good to make it userconfigurable

from cmf-sandbox.

Ok, I need to go inside this implementation in the next 15 days. In the first look, I intend to add a listener on the kernel.request event and do the logic there, priorities, check if cookie exist and move the current logic of the bundle in a BrowserLocaleDetector class that will be called in the listener.

Do you have better ideas or other requirements before I start ? Is somebody else already busy with it ?
One thing where I will need some light is for the cached pages that does not have a locale specified in the url ? The call wil not be done to verify the browser preference with the current implementation of the LocaleBundle ?

Regards,

from cmf-sandbox.

@Kwattro i think the ideal approach would be to refactor the lunetics LocaleBundle to have the priorities and discuss with lunetics about other improvments. and test the interaction when the routing is using _locale (who wins, what should win?)
and then remove the reinventing-the-wheel part i did in the cmf multilang bundle and just keep what is necessary to leverage LocaleBundle

i think having different languages under exactly the same url is very wrong (search engines and bookmarks come to my mind). but it could be ok to have translated urls without a locale if somebody really wants to. like www.example.com/firma and www.example.com/company (note that even in that situation we could have a _locale in the route information)

i am not aware of anybody working on this for the cmf atm, so please go ahead :-) i will try to comment and look at pull requests and such. for design decisions or other input, or technical help as well, you are of course also invited to write to the symfony-cmf google mailinglist.

from cmf-sandbox.

@dbu Ok I will make a PR in the upcoming days and inform it here or in the mailing list.

Regards,

from cmf-sandbox.

lunetics-org/LocaleBundle#5

from cmf-sandbox.

Hello,

I've made some commits against the PR, I've also post in the ML my questions.

Good evening,

Regards,

from cmf-sandbox.

@lsmith77 integrated the bundle into the symfony cmf standard edition. it would be ready to integrate it into the sandbox as well and clean up our homegrown language stuff.

from cmf-sandbox.

#131

from cmf-sandbox.