Giter Club home page Giter Club logo

Comments (4)

bnomei avatar bnomei commented on May 29, 2024

@sylvainjule how to do that?

from kirby-color-palette.

sylvainjule avatar sylvainjule commented on May 29, 2024

The plugin uses the core Query functions, which sanitizes the query result and returns only the text / value pair.
This will probably require switching to a dedicated query method, I'll try to implement it soon.

from kirby-color-palette.

arnoson avatar arnoson commented on May 29, 2024

Is it just me are has this stopped working (trying it in Kirby 3.9.5)

from kirby-color-palette.

arnoson avatar arnoson commented on May 29, 2024

I found the issue: to determine wether the options are from a query, you are testing Object.keys(option).length == 2 (https://github.com/sylvainjule/kirby-color-palette/blob/master/src/components/field/ColorPalette.vue#L147). In recent versions of Kirby, the option has more keys: disabled, icon, info, text, value. I have no idea where they come from, but removing the length check should solve the issue. Or is there a particular reason your are checking for the length? Of course we could just check for a length of 5, but this could break again in future versions.

I can create a PR (but I had to switch from parcel to kirbyup, since I couldn't get it running with parcel).

from kirby-color-palette.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.