Comments (1)
Upon investigation, there are four methods which need to be considered. The URI path component of three of these are constrained by the OpenPGP HTTP Keyserver Protocol (HKP). To make this bug more specific:
(*Client).GetKey()
- uses HKP via(*Client).PKSLookup()
, see below.(*Client).GetVersion()
- should be constructed by appending/version
to any path component specified by(*Config).BaseURL
. This is not consistent with the current behaviour.(*Client).PKSAdd()
- the absolute path is set to/pks/add
(ref). This is consistent with the current behaviour.(*Client).PKSLookup()
- the absolute path is built up of the base request/pks/lookup
, followed by any variables (ref). This is consistent with the current behaviour.
I also took a brief look at how the gpg
command-line behaves when interacting with an HKP key server whose URI includes path component. This command:
gpg --keyserver pool.sks-keyservers.net/test --search-keys blah
Results in an HTTP GET
request to /pks/lookup?op=index&options=mr&search=blah
.
TLDR; this bug includes the behaviour of (*Client).GetVersion()
only. The current behaviour of (*Client).GetKey()
, (*Client).PKSAdd()
and (*Client).PKSLookup()
is correct and should not be modified.
from scs-key-client.
Related Issues (13)
- Don't Set Empty URL Parameters
- Require TLS for Auth Token Use
- Verify Go 1.13 Compatibility
- Verify Go 1.13 Compatibility
- Improve GetKey
- "TLS Required" Error Despite "localhost" Hostname
- Unable to communicate with key server HOT 2
- Dependabot Badge HOT 3
- Update documentation link to pkg.go.dev
- Obtain PKSAdd Response Body
- Improve PKS Errors
- Support HKP and HKPS Schemes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scs-key-client.