Destructuration is broken for custom components about snabbdom-pragma HOT 10 CLOSED

As a sidenote: I think tons of issues are going to disappear.

Right now if I go from <p className="foo">Foo</p> to <p>Bar</p> then the className is not deleted.

Is suspect because it receives null instead of {} ...

from snabbdom-pragma.

Forget it. You do send {} in case of null and you have the tests to verify it, so why do I get destructuration issues 😥

from snabbdom-pragma.

Ok I get it. You don't sanitize props if the sel is a function (custom components). So doing something like

function MyCustomStuff({ someProp }) {
  return <div someProp/>;
}

But using it like this

<MyCustomStuff/>
// which desugars to
h(MyCustomStuff, null, []);
// instead of 
// h(MyCustomStuff, {}, []);

breaks down. Even if we use default arguments in the component implementation (because null !== undefined).

Should we consider this a bug ? Or should we also sanitize props when using custom components ?

from snabbdom-pragma.

Would you accept a PR @Swizz or ?

from snabbdom-pragma.

Any progress on this?

from snabbdom-pragma.

Hi,
I have no ETA on this.
TBH I am not using Snabbdom anymore as I am now a contributor/member of Hyperapp.

Maybe, I will proceed with PR only at the moment.

from snabbdom-pragma.

I have a fix at: https://github.com/blikblum/snabbdom-pragma/tree/allow-components-without-props

waiting for #29 to create the PRs

from snabbdom-pragma.

If anyone is interested i published a package with the fix as snabbdom-pragma-lite.

With bonus you get 30% smaller code, no dependency on extend and 10x faster in real world usage

from snabbdom-pragma.

In case some of you are interested in this, I am open of transferring ownership or adding you as a contributor, as you wish.

from snabbdom-pragma.

I would be happy to take the duty of maintaining it

from snabbdom-pragma.