Use Snackbar instead of Toast everywhere in the app about images-to-pdf HOT 9 CLOSED

Hi @Swati4star, Can I work on this?

from images-to-pdf.

Hi! yeah sure, you can work on this one. But, I would suggest doing the necessary changes for your previous PR first. 👍

from images-to-pdf.

Hello Swati, I want to work on this and am new to open source contribution.

from images-to-pdf.

Hi @subham9777, I have already started working on this. Can you please pick any other issue?

Welcome to the open source community dude.

from images-to-pdf.

Hi @subham9777, @anandkumarkparmar is already working on this. You can pick up any other issue, or you can even create a new one.

from images-to-pdf.

Hi @Swati4star, I have two questions related to this change.

1. Some toast had duration as LENGTH_SHORT and some had LENGTH_LONG. Is it intentional? Or do you want to make it consistent across app(any one of these durations)?

2. Every message string is starting with toast_*. Do you want to change the name of every message which we are showing with Snackbar now?

from images-to-pdf.

1. It is not intentional. You can make the duration as per your wish.
2. Yes please, change the strings also to snackbar_*

from images-to-pdf.

Hi @Swati4star, Please review the pull request.

from images-to-pdf.

This issue is fixed. Thanks to @anandkumarkparmar 👍

from images-to-pdf.