function naming convention about mori HOT 11 CLOSED

Haha, +1 for the bikeshedding issue. Initially, I too was a bit taken aback by the snake_case, but seeing as mori is quite different from other JS libs, the naming convention seems to suit it. Seeing update_in rather than updateIn does give me pause, but in that pause it makes me think harder about what is actually going on.

from mori.

It's unfortunate, but aesthetics matter, and this convention just doesn't blend in with the typical JS naming conventions. Despite how awesome this library seems to be, I'm somewhat reluctant to incorporate it into Atom because I don't want to introduce naming inconsistency to the API.

from mori.

@nathansobo FWIW, immutable.js was just released by someone at Facebook. It was inspired by mori, but with a more JS friendly API. https://github.com/facebook/immutable-js HN discussion: https://news.ycombinator.com/item?id=8107447

from mori.

Or you could always module.exports = require('camelize')(require('mori'))

from mori.

@tgriesser nice

from mori.

After thinking on my previous comment, I hope I didn't come of as complaining. Just wanted to provide feedback on this point. I'm a big admirer of your work @swannodette.

from mori.

@nathansobo plus, to be fair, this isn't even a decision @swannodette made. Basically decisions in lein-cljsbuild are the reason for the funky naming convention.

from mori.

@nathan7 no worries. It's an occasional complaint, but Mori is now an old mostly unidiomatic JavaScript library and I don't really see the value in changing things up at the moment. I think there's value in immutable code sticking out for now - I might change my mind in the future which is why I haven't closed this ticket.

from mori.

@malandrew that's not actually true. Early on (> 2 years) back when hardly anybody in the JavaScript community was interested in immutable data structures I decided to use underscores simply to make the API stick out.

from mori.

@malandrew Just to further clarify: lein-cljsbuild is really just a thin leiningen shell around the various options provided by the ClojureScript compiler. It doesn't affect or impact naming in any way.

from mori.

fixed in master

from mori.