Space added around elements within words about minimize HOT 5 CLOSED

Yeah this is a tricky one, consider the following: <strong>hello</strong> world and/or <a href=#>hello</a> world.

Currently the logic is if inline element and followed by text than remove additional spaces but keep one. The only thing I can think of to fix this is using the original input as reference. If text was originally concatenated then do not add a space, depends on references htmparser2 keeps though. If you have another way of fixing this, I'd like to hear it :)

from minimize.

Could the whitespace reduction not be ran until the (next to) last step? Then the whitespace routine will remove only adjacent whitespaces but still keep one inside block-level elements?

from minimize.

You might be on to something there, hopefully that information still resides in htmparser output somewhere. I'll check asap.

from minimize.

Well, htmlparser2 was updated between versions 3.3.0 and 3.4.0 such that text elements now have next and prev properties. Here's what I came up with: https://github.com/DSKrepps/minimize/commit/75ba00e0c1c43237b1340b3952290ee6dc95d02e

I've changed the behavior so now, instead of trimming all whitespace before adding it in certain cases, it checks for inline elements and collapses whitespace down to a space next to them. The text and tag functions were simplified. A few tests were updated, removed, and added to reflect the new behavior.

As far as I can tell, no changes in whitespace visible in the browser occur with this update, except Hello<a> <i>Erroneous</i> </a>World comes out as one word. This was present beforehand also.

Hope this helps.

from minimize.

Hello<a> <i>Erroneous</i> </a>World messes with my OCD anyways, the workaround is easy ofc ;)

from minimize.