Boolean attributes should only be considered as such on elements that define them about minimize HOT 5 CLOSED

I see where your coming from, but the specific example is merely a test case (with bad HTML admittedly). Now I don't mind improving the test so it actually has disabled on an input. But could you provide an example where this actually breaks output? Developers are still required to write valid HTML, minimize will not be able to fix bad HTML.

from minimize.

We spotted the issue at work were we use Angularjs and custom directives.
One of them allowed "disabling " which was data bound to expression
specified on attribute disabled. Minimize removes the expression leaving
just an empty attribute.

Now, of course we can change the name of the attribute used by the
directive or enable option spare, but I still think that these attributes
should not be touched here.
8 gru 2014 12:51 "Martijn Swaagman" [email protected] napisał(a):

I see where your coming from, but the specific example is merely a test
case (with bad HTML admittedly). Now I don't mind improving the test so it
actually has disabled on an input. But could you provide an example where
this actually breaks output? Developers are still required to write valid
HTML, minimize will not be able to fix bad HTML.

—
Reply to this email directly or view it on GitHub
#27 (comment).

from minimize.

ok so you had something like this <img disabled="disabling"> being turned into <img disabled>? I think you got a point here, the only serious downside I see with this is maintaining all lookup tables per element/groups of elements.

from minimize.

Yes, you got that right. Actually in our case we had an "element" directive, i.e. a new html element, something like <myimg disabled="disabling" />

from minimize.

Fixed and released as v1.2.0

from minimize.