Conditionals not working about minimize HOT 7 CLOSED

Did you turn on conditionals?
Seems the RegEx should pick it up.

from minimize.

Sure... conditionals:true =)
Everything works fine... except conditionals.. =/

Maybe some cache in node?

2014-04-08 14:19 GMT-03:00 tomByrer [email protected]:

Did you turn on conditionals https://github.com/Moveo/minimize#usage?
Seems the RegExhttps://github.com/Moveo/minimize/blob/master/lib/helpers.js#L12should pick it up.

Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-39875985
.

Pedro Pisandelli

from minimize.

Taking a look at this now, perhaps the regexp is too strict or has some flaw

from minimize.

Hi @Swaagie ... yes.. maybe =(
I tried to built another regex with a great help from regex101.com:

\[if.*IE[\s\d]*\]\>(?:[^\n]*(\n*))+\<!\[endif\]/gi

It validated my code in many circumstances, like:

[if lt IE10]>
<p class="browsehappy">
   You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.
</p>
<![endif]

and

[if lt IE 10]><p class="browsehappy">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p><![endif]

Do you think it´s ok, or can we have a more "lean" regex?

Regards,

from minimize.

It might be OK, or perhaps this tester is not working: http://regexr.com/38m9d
Also, is lowercase ie in conditionals OK? IIRC I used lower-case, but all examples use upper.

from minimize.

nasty regexes, currently the RegExp are stored in a var, so once it executes the result is stored. The next time you execute it again it will fail. Pushing fix in a few minutes.

from minimize.

Awesome!
I´ll test it soon!

Thanks guys!

from minimize.