Comments (12)
I guess it goes like
type ComponentProps<T> = T extends React.ComponentType<infer P> | React.Component<infer P>
? JSX.LibraryManagedAttributes<T, P>
: never;
interface IProps {
name: string;
}
interface IDefaultProps {
age: number;
}
const GreetComponent = ({ name, age }: IProps & IDefaultProps) => (
<div>{`Hello, my name is ${name}, ${age}`}</div>
);
const defaultProps: IDefaultProps = {
age: 25,
};
GreetComponent.defaultProps = defaultProps;
// later
const TestComponent = (props: ComponentProps<typeof GreetComponent>) => {
return (
<div> <h1 /> </div>
);
};
const el = <TestComponent name="foo" />;
from react-typescript-cheatsheet.
@sw-yx My point is (and that's my understanding of @gausie problem)
type Props = React.ComponentProps(typeof GreetComponent) // all props are required
type Props = ComponentProps<typeof GreetComponent> // using helper, defaulted props are optional
Extracting props with JSX.LibraryManagedAttributes
is more in line with the old practice marking default props as optional on an interface like interface Props extends Partial<DefaultProps> { /* ... */ }
and using it later.
Consdider this
interface Props extends ComponentProps<typeof GreetComponent> {
title: string;
}
const TestComponent = ({ title, ...props }: Props) => {
return (
<>
<h1>{title}</h1>
<GreetComponent {...props} />
</>
);
};
// age is optional on an inner component's props interface
const el = <TestComponent name="Johnny 5" title="foo" />;
Just thought it was worth mentioning as it was not immediately obvious
from react-typescript-cheatsheet.
ok what do you recommend i put in the cheatsheet?
from react-typescript-cheatsheet.
from react-typescript-cheatsheet.
have you reported this as a bug? (is this a bug? i think it is?)
from react-typescript-cheatsheet.
from react-typescript-cheatsheet.
just try :) good luck
from react-typescript-cheatsheet.
Do you have a code example for this? I would also open this as an issue in the DefinitelyTyped repo instead so the other React types maintainers can take a look.
from react-typescript-cheatsheet.
thanks for the input @infctr! i dont quite see the point of TestComponent.
- if i replace your impl of ComponentProps with the official one
React.ComponentProps
, i see that TestComponent errors because of the missingage
default prop. - if i then add
TestComponent.defaultProps = defaultProps;
it typechecks.
this seems correct behavior.
@gausie, can we please see an example that you expect to work? otherwise its very hard to discuss.
from react-typescript-cheatsheet.
That's correct. There are valid use cases for extracting both the inner props of a component, or the apparent props (with JSX.LibraryManagedAttributes
). The built-in React types only take care of the first case.
from react-typescript-cheatsheet.
hoo boy. ok. thank you
from react-typescript-cheatsheet.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!
from react-typescript-cheatsheet.
Related Issues (20)
- [Basic] useReducer: type safe dispatcher call HOT 2
- "Props: One or the Other but not Both" does not work HOT 2
- [Question] QUESTION_TITLE_HERE
- [Advanced] Wrapping/Mirroring a Component with ref forwarding
- facing errors
- not working
- Gene Piki wants to pay 0 USD to have this issue fixed
- JSX.Element is Deprecated HOT 11
- [Bug] The logo text is overflowing in small devices it should be truncate like mobile navigation. HOT 5
- Update CSS So that website can be accessible from any device of any width -- Solved HOT 8
- [Basic] Add resources to basic/recommended/talks.md HOT 3
- [Basic] Want to Fix Navbar Text Issue Without Truncating And Decreased Footer Logo Size Responsively For all Devices HOT 3
- Table of Content HOT 2
- Linked article on defaultProps docs is paywalled HOT 3
- add as a contributor? HOT 7
- [Basic] Linting page links are not working HOT 6
- CLASS METHODS AND CLASS PROPERTIES TITLES INTERCHANGED HOT 3
- [Advanced] ISSUE_TITLE_HERE
- [Advanced] Restrict useage of child component only as a child of a particular component HOT 3
- [Basic] Provide some docs on `memo` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-typescript-cheatsheet.