Question: In src/errors.rs, why are ContextualErrorKind and ContextualError declared separately? about miniserve HOT 5 CLOSED

from miniserve.

It's this pattern: https://rust-lang-nursery.github.io/failure/error-errorkind.html

from miniserve.

Given its high maintenance cost, and its convoluted usage (Err(ContextualError::new(ContextualErrorKind::<name>(...)))), I don't see the advantage of this pattern.

from miniserve.

@boastful-squirrel did this part so maybe they can provide some insight here.

from miniserve.

That's from when I was using failure's context() method, see the link that @svenstaro posted. Now that I don't use the context() feature anymore, all methods could return a ContextualErrorKind and you could simply write ContextualErrorKind::<name> everywhere.

The reason I didn't remove the ContextualError type yet is because I keep playing with failure to see if there is a way to have the errors the way they are now using failure's context, but well, still not yet.

So if @svenstaro agrees, we could totally drop those calls everywhere. If so, should I include that in my current PR ? While I'm a it... Or another one ?

EDIT: you already did it, cool

from miniserve.